-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix timecop freeze by ignoring nanosecond precision for ci #8411
fix timecop freeze by ignoring nanosecond precision for ci #8411
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8411 +/- ##
==========================================
+ Coverage 81.87% 82.01% +0.14%
==========================================
Files 101 101
Lines 5902 5900 -2
==========================================
+ Hits 4832 4839 +7
+ Misses 1070 1061 -9
|
Hey @jywarren @cesswairimu @VladimirMikulic @Uzay-G this might fix the problem not sure though 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 🚀 . Lets merge this and keep the issue open and monitor this to the next week see how it does. Thanks
Fixes #8401
fixed timecop freeze by ignoring nanosecond precision for ci since the test was failing on Travis because of nanoseconds drift. Check travisjeffery/timecop#97 (comment)
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!