Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timecop freeze by ignoring nanosecond precision for ci #8411

Merged
merged 1 commit into from
Sep 20, 2020

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #8401

fixed timecop freeze by ignoring nanosecond precision for ci since the test was failing on Travis because of nanoseconds drift. Check travisjeffery/timecop#97 (comment)

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Sep 19, 2020

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #8411 into main will increase coverage by 0.14%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8411      +/-   ##
==========================================
+ Coverage   81.87%   82.01%   +0.14%     
==========================================
  Files         101      101              
  Lines        5902     5900       -2     
==========================================
+ Hits         4832     4839       +7     
+ Misses       1070     1061       -9     
Impacted Files Coverage Δ
app/models/node.rb 91.69% <86.66%> (+0.32%) ⬆️
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@Tlazypanda
Copy link
Collaborator Author

Hey @jywarren @cesswairimu @VladimirMikulic @Uzay-G this might fix the problem not sure though 😅

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🚀 . Lets merge this and keep the issue open and monitor this to the next week see how it does. Thanks

@cesswairimu cesswairimu merged commit 8714b73 into publiclab:main Sep 20, 2020
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce intermittent Travis test failures doing math properly with Time
2 participants