remove show more tags in favor of add tags now that both buttons do t…

[jywarren]

…he same thing

follow-up to #8386

[gitpod-io]

[codecov]

Codecov Report

Merging #8400 into main will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8400      +/-   ##
==========================================
+ Coverage   81.89%   81.99%   +0.09%     
==========================================
  Files         101      101              
  Lines        5900     5899       -1     
==========================================
+ Hits         4832     4837       +5     
+ Misses       1068     1062       -6     

Impacted Files	Coverage Δ
app/models/tag.rb	97.51% <ø> (ø)
app/controllers/notes_controller.rb	83.46% <100.00%> (ø)
app/controllers/tag_controller.rb	81.40% <100.00%> (-0.06%)	⬇️
app/controllers/wiki_controller.rb	85.40% <100.00%> (ø)
app/models/node.rb	91.51% <100.00%> (-0.18%)	⬇️
app/api/srch/search.rb	70.06% <0.00%> (+3.82%)	⬆️
app/services/execute_search.rb	94.44% <0.00%> (+5.55%)	⬆️

[jywarren]

ERROR["test_adding_a_location_to_the_wiki", #<Minitest::Reporters::Suite:0x00007fc097c30190 @name="PostTest">, 126.729902146]
 test_adding_a_location_to_the_wiki#PostTest (126.73s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find css ".tags-list a.show-more-tags"
            test/system/post_test.rb:204:in `block in <class:PostTest>'

[jywarren]

Minitest::UnexpectedError: Capybara::ElementNotFound: Unable to find css "#tags a#tags-open"

[jywarren]

This should be tested in GitPod, logged in and not, and on the profile page.

Equiv page: https://stable.publiclab.org/notes/anngneal/12-08-2017/7-ways-to-measure-monitor-and-evaluate-water-quality

[jywarren]

ERROR["test_adding_a_location_to_the_wiki", #<Minitest::Reporters::Suite:0x00007f2ef09841a0 @name="PostTest">, 164.49098691499998]
 test_adding_a_location_to_the_wiki#PostTest (164.49s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find css "#tags a#tags-open"
            test/system/post_test.rb:204:in `block in <class:PostTest>'

[jywarren]

ERROR["test_adding_a_location_to_the_wiki", #<Minitest::Reporters::Suite:0x00007f6ec4e85a00 @name="PostTest">, 147.309467035]
 test_adding_a_location_to_the_wiki#PostTest (147.31s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find css "#tags a.tags-open"
            test/system/post_test.rb:204:in `block in <class:PostTest>'

[jywarren]

OK - noting that the test test 'adding a location to the wiki' do reloads the page to show the inline map, and so this has probably interrupted the tags-open selector. But also $('#tags a#tags-open') didn't work, while $('a#tags-open') did, so I'll try that.

[jywarren]

This remains:

 FAIL["test_adding_a_tag_to_a_user_profile", #<Minitest::Reporters::Suite:0x00007f0ec9b8cb38 @name="TagTest">, 171.61630327000003]
 test_adding_a_tag_to_a_user_profile#TagTest (171.62s)
        Expected: "specialgroup"
          Actual: "zoom:10"
        test/system/tag_test.rb:50:in `block (2 levels) in <class:TagTest>'
        test/system/tag_test.rb:49:in `block in <class:TagTest>'

Within test 'adding a tag to a user profile' do

[jywarren]

Failing because we no longer show the new tag form on profile pages for some reason??

[jywarren]

Hooray!!!