set up gitpod builds for every PR

[keshavsethi]

Here I am just testing gitpod with some changes
Thanks!

fixes #8122

[codecov]

Codecov Report

Merging #8145 into main will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8145      +/-   ##
==========================================
- Coverage   82.05%   82.05%   -0.01%     
==========================================
  Files         100      100              
  Lines        5772     5755      -17     
==========================================
- Hits         4736     4722      -14     
+ Misses       1036     1033       -3     

Impacted Files	Coverage Δ
app/controllers/comment_controller.rb	86.95% <0.00%> (-0.28%)	⬇️
app/controllers/application_controller.rb	92.17% <0.00%> (-0.14%)	⬇️
app/controllers/users_controller.rb	82.16% <0.00%> (-0.13%)	⬇️
app/models/user.rb	86.39% <0.00%> (-0.05%)	⬇️
app/services/search_service.rb	95.04% <0.00%> (-0.05%)	⬇️
app/models/node.rb	91.05% <0.00%> (-0.02%)	⬇️
app/models/tag.rb	97.50% <0.00%> (-0.02%)	⬇️
app/models/answer.rb	100.00% <0.00%> (ø)
app/models/comment.rb	76.89% <0.00%> (ø)
app/api/srch/search.rb	66.24% <0.00%> (ø)
... and 13 more

[jywarren]

Just noting i added some database configs to #8122 too, so let's see...

[jywarren]

ooh! yeah..... good call!

[jywarren]

also try all of these! https://github.com/publiclab/plots2/pull/8122/files#diff-4e0c28ccf9ba5766935eb3f7e564693dR18-R26

[gitpod-io]

[keshavsethi]

@jywarren I think it will setup db now Please review
Thanks!!

[jywarren]

wow! Hope so! 🎉 thank you! My build has taken >24m so far, in #8122

but once prebuilt, hopefully it'll go faster.

[jywarren]

OK, i had to, in the console, run:

yarn install bundle exec passenger start

(last line instead of passenger start)

and then it worked!!!

[jywarren]

https://3000-bcf37db2-e88f-40ad-8f72-1239821526d6.ws-us02.gitpod.io/tags -- very nice!

[jywarren]

Added those last tweaks... hey tremendous job @keshavsethi -- thank you!

Fingers X this passes, then we'll be zooming along!

[keshavsethi]

@jywarren I think we can remove this file??

[jywarren]

possibly! want to try?

[keshavsethi]

@jywarren I checked gitpod after removing. Buil did getting failed so added it again.
Thanks!!

[jywarren]

Hmm. synax still wrong:

mysql -e "SET @@global.sql_mode=(SELECT REPLACE(@@global.sql_mode, 'ONLY_FULL_GROUP_BY', ''));"

[jywarren]

hmm there must be a syntax error in here, but I'm not sure where!

[jywarren]

(Also depending on the mysql version, the syntax may be different, but I believe this one is good for us as I tested it on the console. Ref: https://stackoverflow.com/questions/23921117/disable-only-full-group-by)

[jywarren]

@keshavsethi I kind of got stuck here but maybe you can figure out the next step? Or if @icarito has an idea?

[icarito]

I believe the issue is here, there's a ; and then &&, this is a syntax error.

[jywarren]

Hmm, after this fix we still see it:

gitpod /workspace/plots2 $  HISTFILE=/workspace/.gitpod/cmd-0 history -r; {
> bundle install --without production && cp config/database.yml.gitpod config/database.yml && mysql -e "SET @@global.sql_mode=(SELECT REPLACE(@@global.sql_mode, 'ONLY_FULL_GROUP_BY', ''));" && mysql -e "CREATE DATABASE plots;"; && cp db/schema.rb.example db/schema.rb && rake db:setup && yarn install
bash: syntax error near unexpected token `&&'
gitpod /workspace/plots2 $ 
gitpod /workspace/plots2 $ } && {
bash: syntax error near unexpected token `}'
gitpod /workspace/plots2 $ passenger start
bash: passenger: command not found
gitpod /workspace/plots2 $ 
gitpod /workspace/plots2 $ }
bash: syntax error near unexpected

But, actually there's a ; on the next line too, so I'll try removing that.

[jywarren]

That did it. Perfect:

https://3000-a8cc69d8-8dd5-4128-93f5-1816a29b5f96.ws-us02.gitpod.io/

[jywarren]

Thanks, everyone. This is really exciting. Adding a badge to the README too. 🎉 🎉 🎉

@keshavsethi @Tlazypanda @cesswairimu @sagarpreet-chadha @Shulammite-Aso @keshav234156 @NitinBhasneria @shreyaa-sharmaa @SidharthBansal if you rebase or resync your PRs on plots2 now, you should get a GitPod build here too!

Great for testing integrations, checking UI changes on PRs (esp from first-timers), all kinds of things. Woohoo!!!!

[jywarren]

Aww, it looks like we didn't actually completely solve #8145 (comment) -- I'm trying to work on it a bit more in #8152 now!

[sagarpreet-chadha]

Wow this is so cool!!!
So we have a docker container running in server, which is listening to github PR's using github webhooks, right?

[jywarren]

I believe so but basically it's hosted at GitPod, free!

[jywarren]

Just confirming that we see an error on https://3000-ff07100e-6fdf-4fbe-b308-983437a28749.ws-us02.gitpod.io/wiki --

Mysql2::Error: Expression #26 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'plots.node_revisions.vid' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by: SELECT  `node`.`nid` AS t0_r0, `node`.`vid` AS t0_r1, `node`.`type` AS t0_r2, `node`.`language` AS t0_r3, `node`.`title` AS t0_r4, `node`.`uid` AS t0_r5, `node`.`status` AS t0_r6, `node`.`created` AS t0_r7, `node`.`changed` AS t0_r8, `node`.`comment` AS t0_r9, `node`.`promote` AS t0_r10, `node`.`moderate` AS t0_r11, `node`.`sticky` AS t0_r12, `node`.`tnid` AS t0_r13, `node`.`translate` AS t0_r14, `node`.`cached_likes` AS t0_r15, `node`.`comments_count` AS t0_r16, `node`.`drupal_node_revisions_count` AS t0_r17, `node`.`path` AS t0_r18, `node`.`main_image_id` AS t0_r19, `node`.`slug` AS t0_r20, `node`.`views` AS t0_r21, `node`.`latitude` AS t0_r22, `node`.`longitude` AS t0_r23, `node`.`precision` AS t0_r24, `node_revisions`.`vid` AS t1_r0, `node_revisions`.`nid` AS t1_r1, `node_revisions`.`uid` AS t1_r2, `node_revisions`.`title` AS t1_r3, `node_revisions`.`body` AS t1_r4, `node_revisions`.`teaser` AS t1_r5, `node_revisions`.`log` AS t1_r6, `node_revisions`.`timestamp` AS t1_r7, `node_revisions`.`format` AS t1_r8, `node_revisions`.`status` AS t1_r9 FROM `node` LEFT OUTER JOIN `node_revisions` ON `node_revisions`.`nid` = `node`.`nid` WHERE (node_revisions.status = 1 AND node.status = 1 AND (type = 'page' OR type = 'tool' OR type = 'place')) GROUP BY node_revisions.nid ORDER BY node_revisions.timestamp DESC LIMIT 30 OFFSET 0

line 17 of Trace of template inclusion: app/views/wiki/index.html.erb

15 16 17 18 19 20 | <th><a href = "?sort=likes"> <%= translation('wiki._wikis.likes') %></a> <i class="fa fa-sort" aria-hidden="true"></i></th>     </tr>     <% wikis.each do \|wiki\| %>       <tr>         <td style="width:50%"><i class="fa fa-file"></i> <a href="<%= wiki.path %>"><%= wiki.latest.title %></a></td>         <td><i><%= wiki.path %></i></td>
-- | --

[icarito]

yes, some of our queries seem to be incompatible with MySQL 5.7 - I ran into this with our recent upgrade. In Cloud SQL I added the flag: sql_mode="TRADITIONAL" and it started working.

[jywarren]

MySQL 5.7 and higher? Thanks for the tip, i'll try that!

[jywarren]

addressing in #8152