Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve accessibility of login modal #7968

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #7967

Improved accessibility of Login Modal by modifying orphaned form labels for username and password. Changed suspicious link text 'here' to 'reset it here' for password reset. And added aria-labels for social icons.

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshots

Before

7967_before

After

7967_after

Thanks!

@Tlazypanda Tlazypanda requested review from a team as code owners May 28, 2020 21:36
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #7968 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7968   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files          97       97           
  Lines        5642     5643    +1     
=======================================
+ Hits         4629     4630    +1     
  Misses       1013     1013           
Impacted Files Coverage Δ
app/controllers/stats_controller.rb 73.62% <100.00%> (+0.29%) ⬆️

@jywarren
Copy link
Member

jywarren commented Jun 3, 2020

This is great! Merging!

@jywarren jywarren merged commit 30612c7 into publiclab:master Jun 3, 2020
@jywarren
Copy link
Member

jywarren commented Jun 3, 2020

Can you please give it one last test on stable.publiclab.org? Just because signup and log in are critical systems. Thank you!!!! Great work!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accessibility of Login modal
2 participants