remove cdn links from new.html.erb which are available from asset pip…

[Tlazypanda]

…eline

Fixes #7917
Since the asset pipeline already had some assets available so removed those cdn links.
Tested by

• setting the asset.compress mode to True and assets.debug mode to false
• removing the cdn links and checking if it affected the upload csv option

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Screenshots attached -

Before

After

Thanks!

[codecov]

Codecov Report

Merging #7943 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7943   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files          97       97           
  Lines        5642     5642           
=======================================
  Hits         4629     4629           
  Misses       1013     1013           

Impacted Files	Coverage Δ
app/controllers/stats_controller.rb	73.33% <100.00%> (ø)

[Tlazypanda]

@jywarren @cesswairimu just to confirm the chart.js and popper.js is the same as the ones we already have right ?

Also for popper.js, it is present in package.json but not called anywhere except this file. So it might be better to serve it from a cdn since it will be faster this way 😅

Thanks ✌️

[Tlazypanda]

Hey @jywarren @cesswairimu @emilyashley Looking forward to your input on this 😄

[jywarren]

Hi!! Sorry for slow reply... if we're not around also please see if other Outreachy/GSoC folks are able to help review?

As to Popper, i believe it's a Bootstrap dependency?

Looking now though! Thanks so much!!!

[jywarren]

This looks good to me! Perhaps @IshaGupta18 may want to chime in, otherwise we are good to merge this!

[Tlazypanda]

@jywarren Thanks so much for the review ❤️

[cesswairimu]

Thanks @Tlazypanda 🎉