-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Uglifier gem to minify js #7937
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7937 +/- ##
==========================================
+ Coverage 82.04% 82.16% +0.12%
==========================================
Files 97 97
Lines 5642 5642
==========================================
+ Hits 4629 4636 +7
+ Misses 1013 1006 -7
|
travis has been running forever on this 🤔 @Tlazypanda try closing the PR and reopening |
@cesswairimu Travis passed yay!! 😄 |
@jywarren @cesswairimu @emilyashley @SidharthBansal @VladimirMikulic can you kindly review? Thanks ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, the harmony mode will allow us to use ES6 so that is nice.
@Uzay-G Thanks a lot for the review 😄 |
Love this! Merging!!! |
Fixes #7887
Uglifier gem is configured to minify javascript files.
Tested in development by setting the asset compilation as true(setting the config.assets.debug to false and config.assets.compile to true in development.rb) and checking the asset files.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowThanks!