Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t -> translation #7881

Closed
wants to merge 1 commit into from
Closed

t -> translation #7881

wants to merge 1 commit into from

Conversation

anshalshukla
Copy link

@anshalshukla anshalshukla commented May 6, 2020

Fixes #7703 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented May 6, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #7881 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7881   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files          97       97           
  Lines        5645     5645           
=======================================
  Hits         4632     4632           
  Misses       1013     1013           

@anshalshukla
Copy link
Author

@Shulammite-Aso please take a look at the PR.

Copy link
Member

@ananyaarun ananyaarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks !!

@jywarren
Copy link
Member

Hi, thank you so much! i'd like to request a screenshot of this if possible, following tips at #7798 (comment) -- basically, we are pretty wary of using this translation helper inside of HTML as it has caused some layout disruption!

You should be able to check it to be sure using the tips here: #7798 (comment)

Thank you!

@jywarren
Copy link
Member

And cc'ing @Shulammite-Aso @ananyaarun @govindgoel @publiclab/reviewers about these translation just so you're aware! Thank you!

@anshalshukla
Copy link
Author

@jywareen will share it soon

@jywarren jywarren changed the base branch from master to main June 30, 2020 18:08
jywarren added a commit that referenced this pull request Oct 2, 2020
@jywarren
Copy link
Member

jywarren commented Oct 2, 2020

I'm going to try to rebase this and rework it at #8450 -- thank you all for your help!!!

@jywarren jywarren closed this Oct 2, 2020
jywarren added a commit that referenced this pull request Oct 2, 2020
jywarren added a commit that referenced this pull request Oct 13, 2020
jywarren added a commit that referenced this pull request Oct 13, 2020
jywarren added a commit that referenced this pull request Oct 13, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change function t to translation in app/views/tag/show/_nav_tabs.html.erb
4 participants