-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t -> translation #7881
t -> translation #7881
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## master #7881 +/- ##
=======================================
Coverage 82.05% 82.05%
=======================================
Files 97 97
Lines 5645 5645
=======================================
Hits 4632 4632
Misses 1013 1013 |
@Shulammite-Aso please take a look at the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks !!
Hi, thank you so much! i'd like to request a screenshot of this if possible, following tips at #7798 (comment) -- basically, we are pretty wary of using this translation helper inside of HTML as it has caused some layout disruption! You should be able to check it to be sure using the tips here: #7798 (comment) Thank you! |
And cc'ing @Shulammite-Aso @ananyaarun @govindgoel @publiclab/reviewers about these translation just so you're aware! Thank you! |
@jywareen will share it soon |
I'm going to try to rebase this and rework it at #8450 -- thank you all for your help!!! |
…publiclab#8451)" (publiclab#8565) This reverts commit 86776c2.
…publiclab#8451)" (publiclab#8565) This reverts commit 86776c2.
…publiclab#8451)" (publiclab#8565) This reverts commit 86776c2.
…publiclab#8451)" (publiclab#8565) This reverts commit 86776c2.
…publiclab#8451)" (publiclab#8565) This reverts commit 86776c2.
…publiclab#8451)" (publiclab#8565) This reverts commit 86776c2.
Fixes #7703 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!