Allow bio updation without current password #7806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7806 +/- ##
==========================================
- Coverage 81.94% 81.89% -0.05%
==========================================
Files 97 101 +4
Lines 5627 5894 +267
==========================================
+ Hits 4611 4827 +216
- Misses 1016 1067 +51
|
|
@jywarren @VladimirMikulic can you kindly review ? Thanks ✌️ |
VladimirMikulic
approved these changes
Apr 11, 2020
|
@jywarren @cesswairimu can you kindly review? Thanks ✌️ |
SidharthBansal
requested changes
Apr 21, 2020
app/controllers/users_controller.rb
Outdated
| @@ -57,7 +57,7 @@ def update | |||
| @password_verification = user_verification_params | |||
| @user = current_user | |||
| @user = User.find_by(username: params[:id]) if params[:id] && logged_in_as(['admin']) | |||
| if @user.valid_password?(user_verification_params["current_password"]) || user_verification_params["ui_update"].nil? | |||
| if @user.valid_password?(user_verification_params["current_password"]) || user_verification_params["ui_update"].nil? || (user_verification_params["current_password"].blank? && user_verification_params["password"].blank? && user_verification_params["password_confirmation"].blank?) | |||
| # correct password | |||
There was a problem hiding this comment.
Kindly change this comment
|
Kindly add corresponding unit-test. Thanks for your work |
|
@SidharthBansal Updated pr :) Can you kindly review again? Thanks ✌️ |
SidharthBansal
approved these changes
Apr 22, 2020
|
Thanks |
|
Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈. |
|
Sorry I missed this! All good now!!! Thank you!!! |
shubhangikori
pushed a commit
to shubhangikori/plots2
that referenced
this pull request
Oct 12, 2020
alvesitalo
pushed a commit
to alvesitalo/plots2
that referenced
this pull request
Oct 14, 2020
piyushswain
pushed a commit
to piyushswain/plots2
that referenced
this pull request
Oct 22, 2020
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
ampwang
pushed a commit
to ampwang/plots2
that referenced
this pull request
Oct 26, 2021
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7756
Modified the user controller to allow bio updation without entering current password.
rake test@publiclab/reviewersfor help, in a comment belowGIF
Thanks!