Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select all button #7527

Merged
merged 3 commits into from
Oct 7, 2020
Merged

select all button #7527

merged 3 commits into from
Oct 7, 2020

Conversation

keshavsethi
Copy link
Member

Fixes #7502
Select all issue in dashboard is solved by adding a small function of click all. now it is working fine as shown:
Screenshot from 2020-02-18 00-32-49
@cesswairimu @VladimirMikulic @SidharthBansal
Thanks!

@keshavsethi keshavsethi changed the title select all select all button Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #7527 into main will increase coverage by 0.02%.
The diff coverage is 82.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7527      +/-   ##
==========================================
+ Coverage   81.87%   81.89%   +0.02%     
==========================================
  Files          97      101       +4     
  Lines        5612     5900     +288     
==========================================
+ Hits         4595     4832     +237     
- Misses       1017     1068      +51     
Impacted Files Coverage Δ
app/controllers/application_controller.rb 92.17% <ø> (-0.14%) ⬇️
app/models/concerns/statistics.rb 96.72% <ø> (ø)
app/mailers/admin_mailer.rb 90.90% <12.50%> (-9.10%) ⬇️
app/jobs/digest_spam_job.rb 33.33% <33.33%> (ø)
app/models/user.rb 87.68% <45.00%> (-3.37%) ⬇️
app/controllers/spam2_controller.rb 71.84% <71.84%> (ø)
app/models/comment.rb 77.51% <83.33%> (+0.62%) ⬆️
app/controllers/notes_controller.rb 83.46% <85.71%> (+0.06%) ⬆️
app/controllers/batch_controller.rb 90.19% <90.19%> (ø)
app/controllers/tag_controller.rb 81.45% <90.90%> (+0.96%) ⬆️
... and 45 more

@keshavsethi keshavsethi requested a review from nstjean February 17, 2020 19:19
@nstjean
Copy link
Contributor

nstjean commented Feb 17, 2020

Hi! While this does work, @sssash18 is working on a larger fix for this drop-down menu #7348

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach has a UI flaw, demo.

@keshavsethi
Copy link
Member Author

@VladimirMikulic , Thanks I will correct this.

@keshavsethi
Copy link
Member Author

@VladimirMikulic
Screenshot from 2020-02-18 02-37-37

$('.node-type-all').click(function () {
$('.node-type').prop('checked', this.checked);
});
$('.node-type').change(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be after the .node-type(in the same block). They are both related to checking/unchecking boxes functionality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshavsethi kindly reply

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will make changes.

@jywarren jywarren changed the base branch from master to main June 30, 2020 18:06
@cesswairimu
Copy link
Collaborator

restarting travis

@cesswairimu cesswairimu reopened this Sep 18, 2020
@jywarren jywarren merged commit c2599c2 into publiclab:main Oct 7, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* select all

* select all updated

* select all
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* select all

* select all updated

* select all
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* select all

* select all updated

* select all
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* select all

* select all updated

* select all
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* select all

* select all updated

* select all
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* select all

* select all updated

* select all
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* select all

* select all updated

* select all
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* select all

* select all updated

* select all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkbox select all
6 participants