-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
select all button #7527
select all button #7527
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7527 +/- ##
==========================================
+ Coverage 81.87% 81.89% +0.02%
==========================================
Files 97 101 +4
Lines 5612 5900 +288
==========================================
+ Hits 4595 4832 +237
- Misses 1017 1068 +51
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach has a UI flaw, demo.
@VladimirMikulic , Thanks I will correct this. |
$('.node-type-all').click(function () { | ||
$('.node-type').prop('checked', this.checked); | ||
}); | ||
$('.node-type').change(function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be after the .node-type
(in the same block). They are both related to checking/unchecking boxes functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keshavsethi kindly reply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will make changes.
restarting travis |
* select all * select all updated * select all
* select all * select all updated * select all
* select all * select all updated * select all
* select all * select all updated * select all
* select all * select all updated * select all
* select all * select all updated * select all
* select all * select all updated * select all
* select all * select all updated * select all
Fixes #7502
Select all issue in dashboard is solved by adding a small function of click all. now it is working fine as shown:
@cesswairimu @VladimirMikulic @SidharthBansal
Thanks!