Configurable email settings #3119
Conversation
ghost
assigned 
Generated by 🚫 Danger |
|
Hi @jywarren please review this one Settings Menu look: Here's demo for Like setting: Demo for Indirect comment setting: Thanks! |
|
Wow, this is great. Is there a place we can document the defaults and behaviors in a centralized location and link to there from various parts of the codebase which touch this? Since the defaults aren't obvious maybe. Thanks, Gaurav!!! |
|
Fixes #1610 too, right? |
|
yes, @jywarren we should surely document this! I am a little confused about the location. Would you mind pointing some locations where a "Email Settings" can reside? Thanks! |
|
sure, do you mean the location in the documentation? Or location in the
interface?
…On Mon, Jul 23, 2018 at 1:13 PM Gaurav Sachdeva ***@***.***> wrote:
yes, @jywarren <https://github.com/jywarren> we should surely document
this! I am a little confused about the location. Would you mind pointing
some locations where a "Email Settings" can reside? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ3GwekCtqckgmrUqopKyBFJDqs0Pks5uJgQMgaJpZM4VZnDq>
.
|
|
Location in the documentation 😅 |
|
hmm, i guess maybe in EMAIL.md ?
https://github.com/publiclab/plots2/tree/master/doc/EMAIL.md
…On Mon, Jul 23, 2018 at 2:08 PM Gaurav Sachdeva ***@***.***> wrote:
Location in the documentation 😅
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_FjpJ503CxmxiRwm4ZSgD8iQ9UGks5uJhDfgaJpZM4VZnDq>
.
|
|
@jywarren I would like to open a separate PR for documentation. What do you think? Thanks! |
|
It sounds good. In general I prefer that docs and code be in the same PR as it's easier to trace what happened, and the docs can serve as explanation. But it's fine -- just something to aim for! 👍 👍 👍 |
* email setting for likes * email setting for comment on post you have commented on * test impro * like setting test * indirect comment setting test
Fixes #213
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!