Fallback email and welcome email with Oauth #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Generated by 🚫 Danger |
|
@SidharthBansal I have called the mailer from |
|
Yeah that is sufficient. It will be best if you could check it via testing or on unstable. |
|
Actually, emails can't be sent on unstable.
…On Wed, Jul 11, 2018 at 11:25 PM, Sidharth Bansal ***@***.***> wrote:
Yeah that is sufficient. It will be best if you could check it via testing
or on unstable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3052 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT6S9k3ByHEhacQ-GevJsOPTHh-uPgEBks5uFjwmgaJpZM4VLdKF>
.
|
|
No problem. I will send you details on mail to use the oauth in development. You can check the feature. |
|
Please see your gitter messages |
|
Awesome - ping me when it's ready! Thanks, both of you! |
|
Gaurav as now we are getting 2 messages. I think this pr is ready ?? @Gauravano |
|
Actually, I am thinking of writing a test or just an addition in the previous test |
|
@jywarren its ready to merge! |
|
Great work!!! |
jywarren
pushed a commit
that referenced
this pull request
Jul 12, 2018
* changed color of github icon and refactored code * Update _comment.html.erb (#3048) * changed icons styles * changed env back * some fixes * all icons width set same * fix * added back env * some fix * Update API.md * center align the text * center align and added or * added back env * added spacing in or * added env back * errors on signup page (#3044) * Update .travis.yml * Swap the providers and email-password login (#3021) * Change Login page & remove Gemfile.lock from PR * Add Rails production environment check back in * Uid visible to admin and account holder (#3039) * Uid visible to admin and account holder * few changes * . * minor tweaks * test rectified * .. * test rectified * Fallback email and welcome email with Oauth (#3052) * fallback welcome email * sending welcome mail in oauth * test * added back env * fixes * removed extra spaves
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* fallback welcome email * sending welcome mail in oauth * test
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
…iclab#3050) * changed color of github icon and refactored code * Update _comment.html.erb (publiclab#3048) * changed icons styles * changed env back * some fixes * all icons width set same * fix * added back env * some fix * Update API.md * center align the text * center align and added or * added back env * added spacing in or * added env back * errors on signup page (publiclab#3044) * Update .travis.yml * Swap the providers and email-password login (publiclab#3021) * Change Login page & remove Gemfile.lock from PR * Add Rails production environment check back in * Uid visible to admin and account holder (publiclab#3039) * Uid visible to admin and account holder * few changes * . * minor tweaks * test rectified * .. * test rectified * Fallback email and welcome email with Oauth (publiclab#3052) * fallback welcome email * sending welcome mail in oauth * test * added back env * fixes * removed extra spaves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2241
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!