Configurable Email Settings #2985
Conversation
ghost
assigned 
Generated by 🚫 Danger |
|
Oooh, exciting!!! 👍 |
grvsachdeva
added
summer-of-code
feature
|
Hi @Gauravano, I guess you can now use the customize_digest function in this. It is present in user.rb |
|
Ok, @ViditChitkara, I will add it. Thanks! |
|
Hi @ViditChitkara, I have implemented digest settings in this PR as we have discussed, you can try at https://unstable.publiclab.org/ , I have pushed there. Let me know if any change is required. Thanks! |
|
Hi @jywarren @ViditChitkara this PR is complete. I have incorporated 1 setting and 2 digest settings in this. Please review it, thanks! |
|
This is very exciting - can you post a screenshot once more so we can do a final look at it? |
|
Here's default behavior when the setting is turned on: http://gauravsachdeva.me/default_behaviour.gif Here's the GIF when setting is turned off: http://gauravsachdeva.me/no_comment.gif |
|
@jywarren |
|
This is super. 🎉 Do you want to think with @ViditChitkara about how to ensure /settings and /subscriptions don't confuse people? Could they be on the same page, or could /settings be shown in the menu as Then we should be good to go on this. |
|
We would be adding more settings in the future, currently, 3 more settings are on my checklist too. So, it would be better to keep it as a different page. Coming to the name of the page - as of now all settings will be related to Email, |
|
Yes, let's do "Email settings" and add a link to /subscriptions. Great!
…On Wed, Jul 18, 2018 at 2:02 PM Gaurav Sachdeva ***@***.***> wrote:
We would be adding more settings in the future, currently, 3 more settings
are on my checklist too. So, it would be better to keep it as a different
page. Coming to the name of the page - as of now all settings will be
related to Email, Notification Settings or Email Settings looks good to
me. And, yes, adding a link in subscriptions to settings page is a good
idea. What do you think @ViditChitkara <https://github.com/ViditChitkara>
@jywarren <https://github.com/jywarren>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2985 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_lqxv57TgCRUSqe80GQNG9kNZV2ks5uH3gKgaJpZM4VEAmz>
.
|
|
"Email settings" looks good to me!! |
|
Changing the name and adding a link then. Thanks! |
|
Hi @jywarren here's addition in Subscriptions page Please suggest improvements. Thanks! |
|
This is super! Maybe not bold though? Awesome!
…On Fri, Jul 20, 2018 at 3:56 PM Gaurav Sachdeva ***@***.***> wrote:
Hi @jywarren <https://github.com/jywarren> here's addition in
Subscriptions page
[image: design_1]
<https://user-images.githubusercontent.com/20878070/43022463-07e1f3d6-8c85-11e8-9d7f-00c34868ac2c.png>
Please suggest improvements. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2985 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ31tepbR3E0eUAHffSvOzyFcaDMzks5uIjXhgaJpZM4VEAmz>
.
|
|
Done!
|
|
Super, ready then? 😄 |
|
yes! |
|
Hooray!!! 🎉 |
* comment setting * settings page render * settings page * controller logic * comment direct done * activate button on change * digest settings * fix * fix * fix 2 * clean up * clean up * tests * design change * tweak
Fixes #213
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!