User settings page

[grvsachdeva]

Fixes #2796

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[plotsbot]

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	1 Message
📖	@Gauravano Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[jywarren]

I think this error is intermittent and unrelated -- there's an issue at #2824 ?

Restarted it!

[jywarren]

Great, just a CodeClimate thing - want to approve it?

[grvsachdeva]

hi @jywarren looks you have to Class UsersController has 21 methods (exceeds 20 allowed) . Thanks.

[ViditChitkara]

Great work @Gauravano !! However, we need to come up with a minimum number of tags which need to be added for which a cron job is to be made in scheduler.rb . e.g digest:daily, digest:monthly, digest:daily and so on..Could you have a look at #2772 . I have used def customize_digest(type) method to add and remove these tags. You might want to use them in the controllers, once it gets merged. @jywarren any ideas??

[grvsachdeva]

hi @ViditChitkara , I will adjust my view according to your controller function after your PR will be merged. Thanks.

[ViditChitkara]

Cool 👍

[jywarren]

OK, i'll approve CodeClimate then. I think it's OK. It'll simplify once we get rid of DrupalUsers - #956

Great teamwork folks, just ping me when you're ready!

[grvsachdeva]

Hey @jywarren , @ViditChitkara and I was just discussing whether a user should be able to select only one type of digest from weekly digest and daily digest or not. what do you think about this?

[jywarren]

Ah, like not both? Is there an efficiency or code simplicity reason to not allow both? If there isn't, i guess we can let people get a daily AND weekly digests... odd but maybe someone would like it?

[ViditChitkara]

I thought of it a bit and came to a conclusion that, if we allow both, every week user would get 2 digest mails which is kind of inappropriate (and daily mails too). However, if a user opts for daily digest, he we automatically get weekly mails. While if a user chooses weekly, then most probably he/she wants only weekly mails and not daily. Makes sense??

[jywarren]

Looks like #2772 is done although we are still trying to figure it out (any help appreciated) as it's not sending in production. But are we ready to merge this PR and pick up the settings again? Thanks!

[grvsachdeva]

As we don't have digest template or any final preparation. I think I should close this one for now. I will make the settings page based on current settings in #2985 .Thanks!