Google Authentication #2771

SidharthBansal · 2018-06-05T18:50:04Z

MAIN POINTS TO PONDER IN THIS PULL REQUEST FOR #2676

User able to link/unlink their providers account
Log In
Log out
Sign Up / Sign in
Consideration of corner cases listed in https://publiclab.org/notes/bansal_sidharth2996/02-20-2018/gsoc-proposal-oauth-authentication

Facebook api is working on a test app. But they are changing their settings very often nowadays. So, firstly I am sending pr for Google. Most of the steps are common between different providers. So, once we are done with this. We will quickly have other providers.
@jywarren I will not be able to break into parts this pr. It will be a little longer pr as all code is linked heavily to each other.

This pr is in progress.

plotsbot · 2018-06-05T18:57:36Z

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	1 Message
📖	@SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

SidharthBansal · 2018-06-05T19:02:09Z

Only Google login account will be made as instructions given here. https://scotch.io/tutorials/integrating-social-login-in-a-ruby-on-rails-application#creating-applications.
My app_id and app_secret on developers account is functional. But as I can't share the app_secret so @jywarren you can probably create an account there and change the app_id and app_secret once the pr is merged.

SidharthBansal · 2018-06-07T07:19:02Z

I am making simple text as sign up with google, login with google etc. for now. Later, I will raise a fto issue so that newcomers can add buttons and can add CSS on those buttons.
Or @jywarren if you wish I can also add CSS but as public lab wants more contributors so fto is better.
Thanks

jywarren · 2018-06-07T12:18:03Z

Cool!

…

On Thu, Jun 7, 2018, 3:19 AM Sidharth Bansal ***@***.***> wrote: I am making simple text as sign up with google, login with google etc. for now. Later, I will raise a fto issue so that newcomers can add buttons and can add CSS on those buttons. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7KsJ2Q1Y7yysOLriKOTuKbRAxiSks5t6NPqgaJpZM4UbXRU> .

SidharthBansal · 2018-06-09T05:21:02Z

I am adding commits according to functionality completed and writing a comment so that you can check that functionality code @jywarren. Trying to make the things modular in a pr.
Thanks

SidharthBansal · 2018-06-09T06:09:49Z

Google api in development mode works on http and not on https.

checkpoint 1 Basic Linking and Unlinking of the different providers to the user account

A user who is signed in can link a google/facebook/twitter/github account with the user model via /profile/edit page
A user who is signed in and tries to relink same account then he/she will be notified that the account already has the provider identity.
A user who is signed in and tries to relink different account but of same provider then he/she will be notified that the account already has the provider identity
A user who is signed in and tries to delete the oauth:provider user tag can do so via profile page.
A user can view other user_tags of oauth:providers but cannot delete them.
A user who is signed in can delete the google account and can link another google account with the user model.
I have labelled the commit as checkpoint 1( to make a note that this much we are done with)
A user is able to link only a single account with a user model of a single provider. But can add multiple providers.
Button on the header created
Button on the login page created
Button on the profile/edit created
Button on the sign up created

SidharthBansal · 2018-06-09T06:16:43Z

app/controllers/user_sessions_controller.rb

-          params[:user_session].delete(:password)
-          params[:user_session].delete(:username)
-          params[:openid] = username # pack up username for second runthrough
+      if signed_in?


@jywarren is signed in part is ready. Can you please tell if any changes?

SidharthBansal · 2018-06-09T08:38:02Z

app/controllers/application_controller.rb

+    !!current_user
+  end
+
+  def current_user=(user)


I am having trouble here. Trying to make it work. Any help appreciated.

If this error is solved, it means we are done with login via a provider

OH, can you paste in the error you're having? Perhaps highlight exactly where this is done by the existing login system?

yeah, I marked it just now

jywarren · 2018-06-20T22:06:53Z

I can push it to staging now, actually! Unstable is just a throwaway, but staging is the final check before production. :-)

…

On Wed, Jun 20, 2018 at 5:40 PM Sidharth Bansal ***@***.***> wrote: @jywarren <https://github.com/jywarren> we also need to check that it is working on all 3 sites simultaneously - unstable.publiclab.org - localhost:3000 - publiclab.org Have I missed something? Why do we use staging.publiclab.org? Localhost and production will be done tomorrow 🎉 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ8e2S2A15HDI1bjTPe3xQi4hCE3yks5t-sExgaJpZM4UbXRU> .

jywarren · 2018-06-20T22:08:23Z

pushed to staging! You can watch it build on the Jenkins site.

…

On Wed, Jun 20, 2018 at 6:06 PM Jeffrey Warren ***@***.***> wrote: I can push it to staging now, actually! Unstable is just a throwaway, but staging is the final check before production. :-) On Wed, Jun 20, 2018 at 5:40 PM Sidharth Bansal ***@***.***> wrote: > @jywarren <https://github.com/jywarren> we also need to check that it is > working on all 3 sites simultaneously > > - unstable.publiclab.org > - localhost:3000 > - publiclab.org > Have I missed something? Why do we use staging.publiclab.org? > Localhost and production will be done tomorrow 🎉 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#2771 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABfJ8e2S2A15HDI1bjTPe3xQi4hCE3yks5t-sExgaJpZM4UbXRU> > . >

jywarren · 2018-06-20T22:12:46Z

i forgot the env variables there... adding!

jywarren · 2018-06-20T22:13:14Z

and oops it's actually stable.publiclab.org lol

SidharthBansal · 2018-06-20T22:14:07Z

You can watch it build on the Jenkins site.

can you provide me the link please?

SidharthBansal · 2018-06-20T22:15:04Z

You have written staging in the app

Is it staging or stable?

jywarren · 2018-06-20T22:15:29Z

it's stable. i just changed them all -- whoops!

https://stable.publiclab.org/auth/google_oauth2

jywarren · 2018-06-20T22:16:23Z

rebuilding!

jywarren · 2018-06-20T22:20:32Z

Hmm, stable isn't working, not sure why?

jywarren · 2018-06-20T22:23:05Z

https://jenkins.laboratoriopublico.org/

…

On Wed, Jun 20, 2018 at 6:14 PM Sidharth Bansal ***@***.***> wrote: You can watch it build on the Jenkins site. can you provide me the link please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ8DZE0e7mK2wxcmP4QDordXLo1kpks5t-skwgaJpZM4UbXRU> .

jywarren · 2018-06-20T22:26:18Z

Hmm, did you made changes to docker-compose-stable.yml as well?

jywarren · 2018-06-20T22:26:33Z

yes, i see you did!

jywarren · 2018-06-20T22:30:31Z

uh oh, i see what we merged wasn't precisely the same as this PR - i guess it wasn't squashed, but it should be the same otherwise:

https://jenkins.laboratoriopublico.org/job/Plots-Stable/changes vs
https://jenkins.laboratoriopublico.org/job/Plots-Unstable/changes

jywarren · 2018-06-20T22:47:27Z

It works!! Is it OK that there is a value visible on the profile page?
https://stable.publiclab.org/profile/warren at the very bottom.

SidharthBansal · 2018-06-20T22:51:41Z

Uid can be copied and pasted to be used by another user at most for his or her application. Then if he tries to login he will be asked for password which he does not has. So this will not result in any vulnerability

SidharthBansal · 2018-06-20T23:00:37Z

It will be better if we will open this issue for uid and discuss this there, if needed.
Earlier when I made a PR for identity model creation you told me that uid are visible to all. Hence this will not create any vulnerability.

jywarren · 2018-06-20T23:03:59Z

Ok!!! On Jun 20, 2018 7:01 PM, "Sidharth Bansal" <[email protected]> wrote: It will be better if we will open this issue for uid and discuss this there. Earlier when I made a PR for identity model creation you told me that uid are visible to all. Hence this will not create any vulnerability. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJzhs9TcyhpLC2Wf5ZwLKBInFYxlzks5t-tQVgaJpZM4UbXRU> .

SidharthBansal · 2018-06-20T23:19:42Z

I think now the next and the last step is our actual website www.publiclab.org right?

SidharthBansal · 2018-06-20T23:20:18Z

And then local host so that new developers can use it.

jywarren · 2018-06-20T23:38:51Z

yep!!

…

On Wed, Jun 20, 2018 at 7:20 PM Sidharth Bansal ***@***.***> wrote: And then local host so that new developers can use it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJyJNI7ZTyi5tqGQeaCZTloQ5IyPuks5t-tiygaJpZM4UbXRU> .

jywarren · 2018-06-21T16:09:23Z

We'll be publishing this in the next 10m!

SidharthBansal · 2018-06-21T16:25:50Z

Great

SidharthBansal · 2018-06-21T16:32:29Z

@jywarren the google api is not working on publiclab.org Can you make the changes to the main website before you publish the note? So that Soc people can review it on the main website.
Also, to the localhost.
Thanks

jywarren · 2018-06-21T17:04:28Z

Sorry, we're still working on this, so it won't be running yet!

…

On Thu, Jun 21, 2018 at 12:33 PM Sidharth Bansal ***@***.***> wrote: @jywarren <https://github.com/jywarren> the google api is not working on publiclab.org Can you make the changes to the main website before you publish the note? So that Soc people can review it on the main website. Also, to the localhost. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ_1SptIsHGDaP-lc4bV25d8om18hks5t-8qdgaJpZM4UbXRU> .

SidharthBansal · 2018-06-21T18:37:54Z

@jywarren Last thing remaining in this --> Change the settings so that it will also work for all the developers on localhost:3000 as you indicated in #2855 (comment).
Thanks

SidharthBansal · 2018-06-21T22:29:58Z

Moved to #2892

SidharthBansal · 2018-07-03T16:10:20Z

git push -f https://github.com/publiclab/plots2.git HEAD:unstable

* Routes modified * Set the views * Modified error messages and user_tag * Add User_Tag as identity and find user_tag * User_sessions_controller modified * User_tag modified * user session controller modified * Checkpoint 1 * checkpoint1 codeclimate errors fixed * Checkpoint 2 * checkpoint 2 * User is created from sign up process successfully * create a usertag_with_omniauth * Search a usertag for oauth * search user_tag existing in db * create a user with omniauth test * LOGIN WORKS * current_user=(user) method removed * sign up correction * routing tests for google oauth * Google auth details saved * Google should return omniauth hash test * sign up and login via provider * sign up and login via provider alternative flow * flash message test added * login user with an email and then connect google provider * . * Changes according to rails 5 done * Changes according to rails 5 done * Environment nomenclature updated * Comments added * Adding application.yml * Submitting a draft (publiclab#2747) * Checkbox and JS function added * publish_draft method, routes, mail_notify_stop * coauthor can see and publish * bower update * undo and trying * draft label on dashboard * draft option not visible to first timer * updating bower * debug1 * removing debug statement * button view * view 2 * normal * generate path added * publish privil update * code climate * displaying comment with status1 only * coauthor can view draft * test correction * button text change to save if draft * fixture addition and 1 test * tests , fixtures and minor changes * test addition * codeclimate 1 * codeclimate 2 * codeclimate 3 * minor fixes * enable method=post for data-url image upload at /post (publiclab#2675) * enable method=post for data-url image upload at /post * Update editor_controller.rb * Update editor_controller.rb * Fixed first part of Issue publiclab#2352 Sorting headers added in wiki index page (publiclab#2353) * sorting headers added in wiki index page * replaced sorting header icon * Improved translate widget (publiclab#2553) * enhanced translate widget * changed title formatting of widget * Fix the clone command (publiclab#2766) * List subscription change (publiclab#2767) * Add sidekiq gem (publiclab#2738) * added resque gem * made changes for resqu installation * added sidekiq gem * minor changes * modified docker-compose.yml for redis * minor changes * resolve conflicts * Place tag detection and replacing "-" with "" (publiclab#2734) * Place tag detection and replacing "-" with "" * Javascript changed * Geocode method added * Tweaks * Tweaks * Tweaks * Tweaks 2 * Tweaks 3 * Update Gemfile.lock * Climate fix * add geocoded tags * Tweaks * Block shift and callback to onComplete * onComplete binded with ajax * place in starting of tag detection * Tweaks * make descriptive tag links move to bottom of page (publiclab#2770) * skylight config (publiclab#2773) * Reply to comment by email feature (publiclab#2669) * Added mailman script * Added migration file for adding comment_via column to comment table * Added reverse_markdown gem for converting html to markdown format * Added migration file for adding message_id column to comment table * Added function to handle received mail to create comment * Added icon for comment added via email to distinguish between the normal comment and reply by email comment * Added node_id in Mailer subjects to be used in reply by email feature * Minor changes * Updated schema.rb.example file * Improved tests * Added migrations * Added migrations * Added migrations * Corrected tests * Added enviroment variable for server address * Added sql sphefic conditions * Unwanted changes in schema.rb.example file is removed * Gem added * Log file is moved to public folder * Corrected tests * forward-date timestamps * Rename 20180605190014_add_message_id_column_to_comments.rb to 20180605010014_add_message_id_column_to_comments.rb * Update schema.rb.example * Added whenever cron update command in Makefile for redeploy-container (publiclab#2780) * Fix rss images and email images (publiclab#2784) * Fix rss images and email images * Update rss.rss.builder * Update rss_for_tagged_with_author.rss.builder * Update rss.rss.builder * Update rss.rss.builder * Update notify_node_creation.html.erb * Rails 5.0 upgrade (publiclab#2726) (publiclab#2783) * Rails 5.0 upgrade (publiclab#2726) * Upgraded the .gitignore according to rails diff * Initial Gemfile update * Update README.md * Showing message at the top of upgrade page (publiclab#2713) * added an upgrade alert tag * Additional questions page tweak (publiclab#2721) * added the tag to determine which upgrade is listed on the website * changed regex back * added an upgrade alert tag * added the tag to determine which upgrade is listed on the website * changed regex back * added upgrade after pull and rebase master * Upgrade to Rails 5 * Uncommented composite_primary_key gem * Removed the dual occurence of rails_autolink * Update readme installation, fixes publiclab#2729 (publiclab#2730) Updates the readme to change the installation instructions, fixes publiclab#2729 * Commented activerecord-tableless * Draft display on Dashboard (publiclab#2666) * draft display on dashboard * moderator file view permitted * checking * fix * test fix * Added and modified few config files according to railsdiff.org * Removed mass_assignment_sanitizer * Removed composite primary key gem * Removed all attr_accessible in all models * Added composite_primary_key gem again * Downgraded rails and removed few attr_accessible commands * Added strong parameters to the controllers * Added strong parameters gem and also include params.require inside private methods * Added strongparameters.rb file to initializers folder * Removed unnecessary strong_parameter functions * Removed some errors * Changed test command temporarily in .travis.yml * Corrected config/puma.rb file with adding some assets * Added all the config.precompile files in one line * Removed error of problem in updating of user profile * Removed the error while creating a user * Removed error RecordNotFound: Couldn't find Node with 'nid'= * Removed some errors related to ids * Removed comment.reload in comment_controller_test * Track Dockerfiles accross instances. (publiclab#2593) * Track Dockerfiles accross instances. * Specify jessie as base * Add commands to build&deploy container with Makefile. (publiclab#2746) * Added Sample Cron Job to check working of Whenever Gem (publiclab#2715) * Added Sample Cron Job to test Whenever Gem * Added make targets for deployment and cron service start * Added make to image * Tweak Makefile * Fix cron starting command in Makefile * Trim whitespace * Explicitly set jessie as base container * Fixed codeclimate issues * Auto-set wiki slug (publiclab#2743) * Added keyword arguments to the tag_model.rb * changed the query statement in search method of node.rb * Force removal of pid file (see docker/compose#1393) * Updated the tests due to change in arguments of search function in node.rb * Removed all the failures from tag_controller_test.rb * Changed the style of params in notes_controller_test.rb * Removed all depreciation warnings related to notes_controller * Removed all deprecation warnings related to image_controller and answers_controller * Removed all deprecation warnings of like_controller and fixed syntax error of answer_controller_test.rb * Removed all dep warnings of editor_controller and syntax error of like_controller_test.rb * removed all errors of answer_controller and some errors of tag_controller.rb * Removed all dep warnings of tag_controller_test.rb * Removed several dep warnings * Removed dep warnings of wiki_controller * Removed dep warnings of talk_controller * Removed dep warnings of legacy_controller_test.rb * Removed some warnings related to comment_controller * Removed the syntax errors * Removed two failures regarding application/xml+rss * Removed 2 failures due to wrong way of passing parameters in tests * Removed 2 failures * Fix params * Remove deprecations * Removed some dep warnings * Remove deprecations * Reverted to nothing => true * Reverted to nothing => true * Avoid rendering more than once in the same action * Removed all dep warnings related to user_tags_controller_test * Remove deprecation * Removed Dep warnings * Fix deprecation * Replace before_filter * Remove deprecation * Remove deprecation * Remove deprecation * Remove deprecation * Bump Ruby version to match Travis' * Simplify email regex to work with Ruby 2.4.1 * Changed the ruby version in Dockerfile * Remove deprecation * Remove deprecation * Removed the depreciation warning related to dynamic :controller and :action segment in routes * Changed the default ActiveRecord to ApplicationRecord in models * Clean Gemfile * Reverted to ['nid'] in tag_controller_test.rb * Changed the tests to rake test:all in .travis.yml * Minor spacing correction in .travis.yml * added a commit in application.js an application.css regarding the precompilation of files * Added more indentation * Small fixes * Separated the rails test and jasmine and coveralls task * Modified ['nid'] to ['node']['nid'] * Removed the extra puts in Rakefile * Changed the serial of tests * Added rake/testtask to Rakefile * Removed puma * Changed to ruby 2.4.1-jessie * Removed the whitelist_attributes command from config/application.rb * Removed two failures due to old usage of params * Fixed some new deprecation warnigs introduced * fixes publiclab#2731 'add spam button,line 16 _answers.html.erb' (publiclab#2785) * add spam button,line 16 _answers.html.erb * changed comment.ids to answer.ids * changed from comment path to answer * changed comment.parent.path to answer.path * some more cleanup to the button * change answer.aid to answer id * First timers recaptcha Environment Variables (publiclab#2786) * Edited the if statement * Added the env variables * Edited ENV variable, and added fallback * Fixed issue#2445 added both direction sort order (publiclab#2557) * fixed issue#2445 added both direction sort order * added function get_order_string in tags_controller * Changed get to post (publiclab#2788) * Update container definitions to match actual files used. (publiclab#2791) * Update container definitions to match actual files used. * Fix paths for running docker-compose.yml from subdir * Fix reference to Dockerfile * Reformat range stats page to table (publiclab#2792) * Index page listing for UserTags per issue publiclab#2741. (publiclab#2753) * Index page listing for UserTags per issue publiclab#2741. * Changes per pull request checks. * Removed debugging line. * Added routes to reflect 'groups' naming convention for user_tags per pull request spec. * Tests rewritten after rebase. * Index page listing for UserTags per issue publiclab#2741. * Changes per pull request checks. * Removed debugging line. * Added routes to reflect 'groups' naming convention for user_tags per pull request spec. * Fix for test of sort by value. * Update routes.rb for wiki update (publiclab#2804) * Update routes.rb * fixes * integration tests for assets (publiclab#2806) * integration tests for assets * full assets included * Update assets.rb * Added routes to notes/edit (publiclab#2808) * Added routes to notes/edit * Removed redundant notes#edit and added get instead of post in edit actions * Update routes.rb (publiclab#2810) * Create OPENID.md * fixing error in home_controller related to `group by` (publiclab#2794) * Added group by note.nid * correction * Openid fix with post route and better alert texts (publiclab#2815) * Added group by note.nid * correction * reworded openid requests and added post method for 2nd step * adjust message * Update openid_test.rb * Update openid_test.rb * Update openid_test.rb * Update openid_test.rb * Update Dangerfile (publiclab#2816) * Update routes.rb to fix embeddable features (publiclab#2818) * Update routes.rb * Removed the apostrophe mismatch * Added tests for embed in feature * Delete route for notes (publiclab#2820) * Documentation for the reply-by-email to comment feature (publiclab#2774) * Added documentation for the reply-by-email to comment feature * Added documentation for the reply-by-email to comment feature * Added documentation for the reply-by-email to comment feature * Added documentation for the reply-by-email to comment feature * Re-order comment options and messages (publiclab#2834) * Update _comment.html.erb * Update _comment.html.erb * encoding issue resolved for migrating DrupalUsers to User records (publiclab#2257) * encoding issue solved fixes publiclab#2209 * minor changes * Rename 20180206161706_add_user_for_orphaned_drupal_user.rb to 20180614000000_add_user_for_orphaned_drupal_user.rb * resolves issue 2520 (publiclab#2831) * Emoji autocomplete (publiclab#2832) * basic emoji autocomplete * minor changes * minor tweaks * code climate fixes * minor change * changes * remove unnecessary style * Fix parent powertags for wikis like /barnraising (publiclab#2844) * application.yml added * Views removed * Application.yml removed * application removed * Docker changes * sign up page removed

Routes modified

14eff99

SidharthBansal added the in-progress label Jun 5, 2018

SidharthBansal added this to the Social media integration milestone Jun 5, 2018

SidharthBansal self-assigned this Jun 5, 2018

ghost added the in progress label Jun 5, 2018

jywarren changed the title ~~Google Authentication~~ Google Authentication (in progress) Jun 5, 2018

Set the views

307c2a2

SidharthBansal removed the in progress label Jun 7, 2018

Modified error messages and user_tag

6cbf83c

ghost added the in progress label Jun 8, 2018

SidharthBansal added 2 commits June 8, 2018 14:30

Add User_Tag as identity and find user_tag

5bea168

User_sessions_controller modified

5d145b7

User_tag modified

626555d

user session controller modified

420f94f

SidharthBansal commented Jun 9, 2018

View reviewed changes

SidharthBansal removed the in-progress label Jun 9, 2018

Checkpoint 1

b8a1413

SidharthBansal commented Jun 9, 2018

View reviewed changes

SidharthBansal mentioned this pull request Jun 9, 2018

Community Check-in #3 Summer Of Code Week 4 #2764

Closed

SidharthBansal force-pushed the google_login branch 2 times, most recently from 9c466da to 5e766db Compare June 9, 2018 10:51

checkpoint1 codeclimate errors fixed

cd83f92

SidharthBansal force-pushed the google_login branch from 5e766db to cd83f92 Compare June 9, 2018 12:29

SidharthBansal added the enhancement explains that the issue is to improve upon one of our existing features label Jun 9, 2018

SidharthBansal mentioned this pull request Jun 21, 2018

Google Provider OAuth settings for development #2892

Closed

2 tasks

SidharthBansal added this to the OAuth Login milestone Jul 9, 2018

Google Authentication #2771

Google Authentication #2771

Conversation

SidharthBansal commented Jun 5, 2018 • edited Loading

plotsbot commented Jun 5, 2018 • edited Loading

SidharthBansal commented Jun 5, 2018 • edited Loading

SidharthBansal commented Jun 7, 2018 • edited Loading

jywarren commented Jun 7, 2018 via email

SidharthBansal commented Jun 9, 2018

SidharthBansal commented Jun 9, 2018 • edited Loading

checkpoint 1 Basic Linking and Unlinking of the different providers to the user account

SidharthBansal Jun 9, 2018

Choose a reason for hiding this comment

SidharthBansal Jun 9, 2018

Choose a reason for hiding this comment

SidharthBansal Jun 9, 2018

Choose a reason for hiding this comment

jywarren Jun 11, 2018

Choose a reason for hiding this comment

SidharthBansal Jun 11, 2018

Choose a reason for hiding this comment

jywarren commented Jun 20, 2018 via email

jywarren commented Jun 20, 2018 via email

jywarren commented Jun 20, 2018

jywarren commented Jun 20, 2018

SidharthBansal commented Jun 20, 2018

SidharthBansal commented Jun 20, 2018

jywarren commented Jun 20, 2018

jywarren commented Jun 20, 2018

jywarren commented Jun 20, 2018

jywarren commented Jun 20, 2018 via email

jywarren commented Jun 20, 2018

jywarren commented Jun 20, 2018

jywarren commented Jun 20, 2018

jywarren commented Jun 20, 2018

SidharthBansal commented Jun 20, 2018 • edited Loading

SidharthBansal commented Jun 20, 2018 • edited Loading

jywarren commented Jun 20, 2018 via email

SidharthBansal commented Jun 20, 2018

SidharthBansal commented Jun 20, 2018

jywarren commented Jun 20, 2018 via email

jywarren commented Jun 21, 2018

SidharthBansal commented Jun 21, 2018

SidharthBansal commented Jun 21, 2018

jywarren commented Jun 21, 2018 via email

SidharthBansal commented Jun 21, 2018 • edited Loading

SidharthBansal commented Jun 21, 2018

SidharthBansal commented Jul 3, 2018

SidharthBansal commented Jun 5, 2018 •

edited

Loading

plotsbot commented Jun 5, 2018 •

edited

Loading

SidharthBansal commented Jun 5, 2018 •

edited

Loading

SidharthBansal commented Jun 7, 2018 •

edited

Loading

SidharthBansal commented Jun 9, 2018 •

edited

Loading

SidharthBansal commented Jun 20, 2018 •

edited

Loading

SidharthBansal commented Jun 20, 2018 •

edited

Loading

SidharthBansal commented Jun 21, 2018 •

edited

Loading