Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace .length with .size for notes/_comments.html.erb #8298

Closed
5 tasks
Tlazypanda opened this issue Aug 15, 2020 · 4 comments · Fixed by #8305
Closed
5 tasks

Replace .length with .size for notes/_comments.html.erb #8298

Tlazypanda opened this issue Aug 15, 2020 · 4 comments · Fixed by #8305
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@Tlazypanda
Copy link
Collaborator

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

See this page for some help in taking your first steps!

Following lines need to be changed

4 <h3><span id="comment-count"><%= comments.length %></span> <%= translation('notes._comments.comments') %></h3>

Replace with the following

4 <h3><span id="comment-count"><%= comments.size %></span> <%= translation('notes._comments.comments') %></h3>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@Tlazypanda Tlazypanda added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Aug 15, 2020
@LifeofDan-EL
Copy link
Member

Good day, can I jump on this? If yes, could you assign it to me. Went through your website and I'm interested in contributing to the community in the little way I can.

@Tlazypanda
Copy link
Collaborator Author

Hey @LifeofDan-EL Sure, go ahead! 🎉

@Tlazypanda Tlazypanda added this to the Performance Summer 2020 milestone Aug 15, 2020
@LifeofDan-EL
Copy link
Member

Sure, on it.

@cesswairimu
Copy link
Collaborator

Thanks @Tlazypanda 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants