Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag page heading card not rendering well in mobile screens #6054

Closed
jywarren opened this issue Jul 23, 2019 · 15 comments
Closed

Tag page heading card not rendering well in mobile screens #6054

jywarren opened this issue Jul 23, 2019 · 15 comments
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute high-priority

Comments

@jywarren
Copy link
Member

image

cc @gautamig54 @CleverFool77 would you be able to help with this? I think it relates to not using position:absolute for the card... Thanks!

@jywarren
Copy link
Member Author

Related to #6027 too!

@jywarren jywarren added bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute high-priority labels Jul 23, 2019
@jywarren
Copy link
Member Author

I think it's only https://publiclab.org/tag/coqui doing this ... maybe odd-shaped images? Not sure!

@CleverFool77
Copy link
Member

CleverFool77 commented Jul 23, 2019

Hi Jeff !! I went through the site !! My screenshots are somewhat different :
attached below
Screenshot from 2019-07-23 20-51-36

Screenshot from 2019-07-23 20-49-41
Screenshot from 2019-07-23 20-49-50
Screenshot from 2019-07-23 20-50-12

@jywarren
Copy link
Member Author

OK, good to know! Maybe different devices are showing different things here. Let's keep gathering evidence!

@jywarren
Copy link
Member Author

My screenshot is 685px wide!

@CleverFool77
Copy link
Member

Hi @jywarren I specially checked it in 685px wide and yes it's distorting in that width -
attached image
Screenshot from 2019-07-23 23-21-19

Me and @gautamig54 will try to look into this and give a fix soon.
Thanks !!

@CleverFool77
Copy link
Member

So After trying it on many screens, The UI is distorted only in tab version, otherwise its working fine on different screens.

@gautamig54
Copy link
Contributor

So @CleverFool77 we can use media screen functionality and make it right for the tab view as well. I did it explicitly for the mobile view, you see it in the code.
We can do the similar thing for the tab view also. Maybe just by increasing the maximum width in the media screen to 685px which is currently 480px.
What do you say?

@CleverFool77
Copy link
Member

CleverFool77 commented Jul 25, 2019 via email

@gautamig54
Copy link
Contributor

Sure. I'll try it out!

@gautamig54
Copy link
Contributor

@CleverFool77. I notice that in tab view, the page is not displaying the image with the grey background. It is happening for the mobile view. Why do think this is happening?

Screen Shot 2019-07-27 at 2 37 06 PM

Screen Shot 2019-07-27 at 2 37 18 PM

@CleverFool77
Copy link
Member

So page is not displaying the image with background . Its because this feature is necessary only in medium and above larger screen as usually width of image goes much smaller compares to width of our screens.
Besides, In this I have used two different divs, one is for smaller screen like mobile and other is for screens larger than mobile. So I did add the background on them using bootstrap classes and css.
Is this what you wanted me to explain ?

@gautamig54
Copy link
Contributor

HI @CleverFool77! I am not able to understand why the image is not rendering in the tab view. Can you look into this? I will take care of the tag card positioning and other objects.
You can solve the image part and I will take care of the rest :)

@jywarren
Copy link
Member Author

I looked in the chrome dev console and found that this 'box' class div is potentially the issue?

image

@jywarren
Copy link
Member Author

OK, moving to #6799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute high-priority
Projects
None yet
Development

No branches or pull requests

3 participants