-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about possible slowness when using an older version of pyOpenSSL #4309
Comments
So I think @Lukasa or @sigmavirus24 may have a more definitive answer to this, but it looks like We already require |
Just to be clear, do you mean check that the OpenSSL module is available, or check specifically that the module is pyOpenSSL? |
@PrimordialHelios, I believe that PyOpenSSL is sufficient (and much easier to check). We don't import or use cryptography directly in Requests, so the urllib3 pyopenssl contrib module should be our only point of contact. |
This should be resolved with #4332 merged. Thanks again @PrimordialHelios! |
This comment on #4278 suggests warning about possible slowness for older versions of pyOpenSSL.
I'd love to work on this, I'm just not sure which versions to warn about and would love input from some developers more experienced with the library.
The text was updated successfully, but these errors were encountered: