Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused IsViableForCheckpoint #13879

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Remove unused IsViableForCheckpoint #13879

merged 1 commit into from
Apr 14, 2024

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Apr 14, 2024

IsViableForCheckpoint is no longer used in the chain info package. We should remove it to reduce the potential for bugs. Specifically, if someone attempts to use it in the future, note that the function requires a fork choice lock, which can lead to misuse.

@terencechain terencechain added the Ready For Review A pull request ready for code review label Apr 14, 2024
@terencechain terencechain requested a review from a team as a code owner April 14, 2024 15:12
@terencechain terencechain enabled auto-merge April 14, 2024 15:15
@terencechain terencechain added this pull request to the merge queue Apr 14, 2024
Merged via the queue into develop with commit 5f909ca Apr 14, 2024
17 checks passed
@terencechain terencechain deleted the rm-viable-cp branch April 14, 2024 16:45
nisdas pushed a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants