Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Config To Include Networking Config #12478

Closed
nisdas opened this issue May 31, 2023 · 1 comment · Fixed by #13364
Closed

Update Config To Include Networking Config #12478

nisdas opened this issue May 31, 2023 · 1 comment · Fixed by #13364
Labels
Networking P2P related items Spec

Comments

@nisdas
Copy link
Member

nisdas commented May 31, 2023

💎 Issue

Background

Since ethereum/consensus-specs#3375 has been merged in the consensus-specs repo. We can now bundle both the consensus and networking config data into a single config.

Description

This issue is to track the update of our internal config structure to accommodate this particular change. Some things to be mindful of:

  • Does not break users running custom devnets. Previous flags/configurations used by them still work fine here.
  • This works fine with e2e and our other multiclient testing configurations.
@nisdas nisdas added Networking P2P related items Spec labels May 31, 2023
@anukul
Copy link
Contributor

anukul commented Jul 4, 2023

Duplicate #12547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking P2P related items Spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants