Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for go 1.20 #12043

Closed
7AC opened this issue Feb 24, 2023 · 4 comments · Fixed by polymerdao/prysm#22 or #12333
Closed

Support for go 1.20 #12043

7AC opened this issue Feb 24, 2023 · 4 comments · Fixed by polymerdao/prysm#22 or #12333

Comments

@7AC
Copy link

7AC commented Feb 24, 2023

Prysm indirectly depends on quic-go:

https://github.com/prysmaticlabs/prysm/blob/develop/go.mod#L163

and the version in use is affected by quic-go/quic-go#3630

The issue is fixed in quic-go/quic-go#3641 but it requires upgrading github.com/libp2p/go-libp2p and github.com/libp2p/go-libp2p-pubsub (plus some adjustments).

@7AC
Copy link
Author

7AC commented Feb 24, 2023

This is also relevant prysmaticlabs/gohashtree#6

@prestonvanloon
Copy link
Member

Thanks for filing this @7AC. We need to update to go 1.20 soon and there were a few blockers as you have pointed out. Were you able to make progress in polymerdao#22 and successfully compile with go 1.20?

@7AC
Copy link
Author

7AC commented Feb 24, 2023

@prestonvanloon the current status is I'm hitting prysmaticlabs/gohashtree#6 on macOS and the issue below on ubuntu (importing a few packages from prysm):

Error: ../../../go/pkg/mod/github.com/polymerdao/prysm/[email protected]/encoding/bytesutil/bytes_go120.go:12:17: cannot convert PadTo(x, 4) (value of type []byte) to type [4]byte: conversion of slices to arrays requires go1.20 or later (-lang was set to go1.19; check go.mod)
Error: ../../../go/pkg/mod/github.com/polymerdao/prysm/[email protected]/encoding/bytesutil/bytes_go120.go:19:18: cannot convert PadTo(x, 20) (value of type []byte) to type [20]byte: conversion of slices to arrays requires go1.20 or later (-lang was set to go1.19; check go.mod)
Error: ../../../go/pkg/mod/github.com/polymerdao/prysm/[email protected]/encoding/bytesutil/bytes_go120.go:26:18: cannot convert PadTo(x, 32) (value of type []byte) to type [32]byte: conversion of slices to arrays requires go1.20 or later (-lang was set to go1.19; check go.mod)
Error: ../../../go/pkg/mod/github.com/polymerdao/prysm/[email protected]/encoding/bytesutil/bytes_go120.go:33:18: cannot convert PadTo(x, 48) (value of type []byte) to type [48]byte: conversion of slices to arrays requires go1.20 or later (-lang was set to go1.19; check go.mod)
Error: ../../../go/pkg/mod/github.com/polymerdao/prysm/[email protected]/encoding/bytesutil/bytes_go120.go:40:18: cannot convert PadTo(x, 64) (value of type []byte) to type [64]byte: conversion of slices to arrays requires go1.20 or later (-lang was set to go1.19; check go.mod)
Error: ../../../go/pkg/mod/github.com/polymerdao/prysm/[email protected]/encoding/bytesutil/bytes_go120.go:47:18: cannot convert PadTo(x, 96) (value of type []byte) to type [96]byte: conversion of slices to arrays requires go1.20 or later (-lang was set to go1.19; check go.mod)

Looks like it could be just a matter of changing the version in go.mod? I was reluctant to change it until prysmaticlabs/gohashtree#6 is fixed so we don't break compilation on macOS.

@potuz
Copy link
Contributor

potuz commented Feb 25, 2023

@prestonvanloon I need a timeline on when you need go 1.20 as gohashtree may take me a while to take a look due to other priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants