Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build configuration to use sdk 31 instead #340

Conversation

vincent-paing
Copy link
Contributor

Fixes #327.

Upgrade example and the library project to compile with Sdk version 31 (Android 12). This also added required exported flag in AndroidManifest.xml. I believe there's no reason for external apps to open ChromeTabsManagerActivity, so the exported flag here should be false.

BREAKING CHANGES: By default, it will now use Android 31, so the library user have to upgrade if they don't provide required gradle ext values. I believe this won't impact much since most react native project already specify those sdk versions. Or they could also use override version in AndroidManifest.xml

<uses-sdk android:targetSdkVersion="{VERSION}"
 tools:overrideLibrary="com.proyecto26.inappbrowser"/>

@jdnichollsc
Copy link
Member

Hey dude, thanks for your contribution!

As I can see this is not a breaking change, they can define these versions from android/build.gradle as we already explain in the README of the project. If you want I can merge these changes, but again I don't see a breaking change here 🤔

Best,
Juan

@vincent-paing
Copy link
Contributor Author

Sure in that case, feel free to merge it @jdnichollsc

@jdnichollsc jdnichollsc merged commit 2046857 into proyecto26:develop Apr 6, 2022
@vincent-paing vincent-paing deleted the fix/android_12_exported_requirements branch April 6, 2022 04:39
@vincent-paing vincent-paing restored the fix/android_12_exported_requirements branch April 6, 2022 04:39
@vincent-paing vincent-paing deleted the fix/android_12_exported_requirements branch April 6, 2022 04:39
@jdnichollsc jdnichollsc mentioned this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants