Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default browser for custom tab if any #177

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

thuongtv-vn
Copy link
Contributor

@thuongtv-vn thuongtv-vn commented Jul 31, 2020

PR Checklist

What is the current behavior?

A system popup will be shown if the device has installed multiple browsers or apps that can handle CustomTabsIntent service.

What is the new behavior?

If Chrome is available, then Chrome is the highest priority browser selected, otherwise, the first browser which supports CustomTabsIntent is chosen.

Fixes #149 #107
Implements #86

@jdnichollsc
Copy link
Member

I was wondering if we can include these other options (com.chrome.beta, com.chrome.dev, com.google.android.apps.chrome) too https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/blob/4e540732e0ed33a350ca6cede87da520fca864ce/src/android/helpers/CustomTabsHelper.java#L82

@thuongtv-vn
Copy link
Contributor Author

Hi @jdnichollsc
Absolutely, we can add these packages above as default. I have updated my pull request.

Thank you for your advice!

Cheers!

@jdnichollsc
Copy link
Member

Thanks for your help mate, I'm going to modify your code before to publish the new version! 👍

@jdnichollsc jdnichollsc merged commit a8f4e47 into proyecto26:develop Oct 5, 2020
@jdnichollsc jdnichollsc mentioned this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InAppBrowser.open triggering a open with dialog
2 participants