-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports ephemeralWebBrowserSession on iOS 13 #141
Conversation
Is it possible to add a flag from iOS options in order to enable/disable this? What do you think? |
@avenner have you found an iOS option for this? I can't find anything we can put on Info.plist. +1 for the PR |
Guys, are you agree to merge this PR? |
Sorry guys : @jdnichollsc : very busy last time, I will try to add this as an option Lasts commits was a mistake, will be cleaned soon, sorry for incovenience. |
@avenner no worries! thanks for the help. |
@jorgexgb no need to add nothing in plist, need only to set the session as ephemeral ;) |
( mistake reverted, now looking to add this as an option... ) |
Done & tested. |
6db3c61
to
51f0969
Compare
(extra comma fixed) |
Hello, Actually, on iOS 12+, when you login, the cookie is kept until the app is killed. Since iOS 13 it's possible to make session ephemeral. With this option prefersEphemeralWebBrowserSession, the cookie is killed when tab browser is closed. Pros : - no need to logout manualy users (for account switch for example) Cons : - user should reconnect each time the tab is presented. It fix proyecto26#76 , on iOS 13. TODO : Improvement : make this parameter as an option Best Regards
@avenner thanks!!! |
@avenner seems good! @jdnichollsc let us know if okay to merge |
You are welcome @jorgexgb ! Please note that when this option is activated, there is no prompt before open auth ( "app" wants to use "example.com" ... ) |
@avenner got it. That is totally fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the name of the property, using "ephemeralWebSession" instead of "animated"
Fix property name
Ohh and please include this new option here:
Thanks for your help! 👍 |
Thanks for your contribution! <3 |
Big thanks to you @jdnichollsc and @jorgexgb ! |
I really didn't do anything. @avenner @jdnichollsc you guys did everything! Thanks!!! 👍 |
Ok, check the new version |
Nice ! |
Thanks to you! Sorry for the delay 😄 |
No problem :) |
Supports ephemeralWebBrowserSession on iOS 13
Hello,
Actually, on iOS 12+, when you login, the cookie is kept until the app is killed.
Since iOS 13 it's possible to make session ephemeral.
With this option prefersEphemeralWebBrowserSession, the cookie is killed when tab browser is closed.
Pros :
Cons :
It fix #76 , on iOS 13.
TODO : Improvement : make this parameter as an option
Best Regards
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].