Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mayLaunchUrl and warmup methods in Android #84

Closed
giannismacheras opened this issue Jul 25, 2019 · 2 comments · Fixed by #341
Closed

Add mayLaunchUrl and warmup methods in Android #84

giannismacheras opened this issue Jul 25, 2019 · 2 comments · Fixed by #341
Labels
enhancement New feature or request

Comments

@giannismacheras
Copy link

This would significantly improve performance.

@giannismacheras giannismacheras changed the title Add mayLaunchUrl and warmup methods Add mayLaunchUrl and warmup methods in Android Jul 27, 2019
@jdnichollsc
Copy link
Member

Any pull request is welcome, thanks for report this issue mate! 👍

@jdnichollsc jdnichollsc added the enhancement New feature or request label Jul 28, 2019
@vincent-paing
Copy link
Contributor

vincent-paing commented Apr 6, 2022

Connect to the Custom Tabs service on the onStart() method of the Activities you plan to launch a Custom Tab from.

@jdnichollsc This might require a rewrite of the logic itself. Since the CustomTabsService has to be binded to the calling activity, It wouldn't make sense to do this in ChromeTabsManagerActivity since it gets recreated every time. It has to warmed up in the activity that has user interaction to open custom tabs, i.e, current activity from reactContext. I think we can hook into react lifecycle listeners. Is there a particular reason you felt the need for separate activity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants