Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: reader.skipField is not a function #141

Closed
TA2k opened this issue Oct 8, 2022 · 3 comments · Fixed by #143
Closed

TypeError: reader.skipField is not a function #141

TA2k opened this issue Oct 8, 2022 · 3 comments · Fixed by #143
Assignees
@dibenede
Labels
bug Something isn't working triaged Issue has been triaged

Comments

@TA2k
Copy link

TA2k commented Oct 8, 2022

Since 3.21.1 I receive
TypeError: reader.skipField is not a function

on
deserializeBinary(data).toObject()

with 3.21.0 it is working

Node 16.17.1
@Nihcep
Copy link

Nihcep commented Oct 10, 2022

Same with
reader.readUint64String is not a function
Working with 3.21.0

@George-Payne George-Payne mentioned this issue Oct 10, 2022
Closed
@dibenede
Copy link
Contributor

This definitely looks like the closure optimizations taking out too much. In the deeper details, all of our tests pass closure deps side, but it looks like our jasmine config for commonjs doesn't include most of our binary/ tests.

@dibenede dibenede self-assigned this Oct 10, 2022
@dibenede dibenede added bug Something isn't working triaged Issue has been triaged labels Oct 10, 2022
@kuruk-mm kuruk-mm mentioned this issue Oct 10, 2022
Merged
@dibenede dibenede mentioned this issue Oct 10, 2022
Merged
@dibenede dibenede reopened this Oct 10, 2022
@dibenede
Copy link
Contributor

I just published a hotfix release (3.21.2) to npm and will close this out now. Please re-open and ping me if the problem persists.

This was referenced Apr 12, 2024
Merged
Merged
rubens21 pushed a commit to lugobots/lugo4node that referenced this issue Apr 12, 2024
@katipunan98
upgrading google-protobuf version to stop bug reader.skipField is not…
3da3718 
… a function protocolbuffers/protobuf-javascript#141
@X-oss-byte X-oss-byte mentioned this issue May 24, 2024
Open
@thiswayman thiswayman mentioned this issue May 25, 2024
Open
@Suryaveersingh8055 Suryaveersingh8055 mentioned this issue Jun 5, 2024
Open
@VaniHaripriya VaniHaripriya mentioned this issue Jun 22, 2024
Open
@abhisheksurpur abhisheksurpur mentioned this issue Jul 11, 2024
Open
@kalbroni7 kalbroni7 mentioned this issue Jul 14, 2024
Open
@chenruibuaa chenruibuaa mentioned this issue Jul 22, 2024
Open
@appleboy appleboy mentioned this issue Aug 6, 2024
Merged
@srt0422 srt0422 mentioned this issue Aug 6, 2024
Open
@thiswayman thiswayman mentioned this issue Aug 6, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue Aug 15, 2024
Open
@vroldanbet vroldanbet mentioned this issue Aug 20, 2024
Closed
@ametial ametial mentioned this issue Aug 22, 2024
Open
@evgeniyarbatov evgeniyarbatov mentioned this issue Aug 22, 2024
Open
@searce-nirav searce-nirav mentioned this issue Aug 31, 2024
Open
@swirlds-automation swirlds-automation mentioned this issue Sep 5, 2024
Open
@thiswayman thiswayman mentioned this issue Sep 7, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue Sep 9, 2024
Open
@thiswayman thiswayman mentioned this issue Sep 14, 2024
Open
@yash509 yash509 mentioned this issue Sep 16, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue Sep 22, 2024
Open
@dazdaz dazdaz mentioned this issue Sep 30, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this issue Oct 1, 2024
Open
@ambersnyk ambersnyk mentioned this issue Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibenede dibenede

Labels
bug Something isn't working triaged Issue has been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return to using default closure optimization level dibenede/protobuf-javascript
3 participants
@dibenede @TA2k @Nihcep