Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean and DRY nonbonded potential code #639

Open
3 of 7 tasks
mcwitt opened this issue Feb 16, 2022 · 0 comments
Open
3 of 7 tasks

Clean and DRY nonbonded potential code #639

mcwitt opened this issue Feb 16, 2022 · 0 comments

Comments

@mcwitt
Copy link
Collaborator

mcwitt commented Feb 16, 2022

In the initial implementation of NonbondedInteractionGroup in #578 (and previously in #542), we introduced duplicate code by copying and modifying the original nonbonded potential implementation. We should revisit this at some point to DRY the common parts, and apply some fixes suggested in the above PRs that apply in multiple places.

Miscellaneous items applying to code that currently exists in multiple nonbonded potentials:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant