Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_exporter flag missing running v1.0.1 Docker image #1858

Closed
mikejoh opened this issue Oct 1, 2020 · 2 comments
Closed

node_exporter flag missing running v1.0.1 Docker image #1858

mikejoh opened this issue Oct 1, 2020 · 2 comments

Comments

@mikejoh
Copy link

mikejoh commented Oct 1, 2020

Host operating system: output of uname -a

Linux 5.5.0-050500-generic #202001262030 SMP Mon Jan 27 01:33:36 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

node_exporter version: output of node_exporter --version

node_exporter, version 1.0.1 (branch: HEAD, revision: 3715be6ae899f2a9b9dbfd9c39f3e09a7bd4559f)
  build user:       root@1f76dbbcfa55
  build date:       20200616-12:44:12
  go version:       go1.14.4

node_exporter command line flags

I'm trying to run v1.0.1 of the Dockerized version of node_exporter with the following flag:

--collector.ipvs.backend-labels=remote_port

Are you running node_exporter in Docker?

Yes.

What did you do that produced an error?

docker run --rm quay.io/prometheus/node-exporter:v1.0.1 --collector.ipvs.backend-labels=remote_port
node_exporter: error: unknown long flag '--collector.ipvs.backend-labels', try --help

What did you expect to see?

I'm expecting to see the node_exporter start with the new backend-labels flag. This is working using the master tag of the image. To me it looks like that the fix is missing from v1.0.1 and that the released Docker image didn't include all changes done in the release-1.0 branch. Not at all sure about this though!

@paulfantom
Copy link
Contributor

paulfantom commented Oct 1, 2020

This flag was added in #1709 and those commits are not on release-1.0 branch, so v1.0.1 won't have that change.

@mikejoh
Copy link
Author

mikejoh commented Oct 1, 2020

@paulfantom No you're correct of course, the changes in that PR merged to master and nothing else!

Thanks!

@mikejoh mikejoh closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants