Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promslog: use UTC timestamps for go-kit log style #696

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

dswarbrick
Copy link
Contributor

promlog initialized its go-kit logger to use UTC timestamps, so for true backwards compatibility, the go-kit log style in promslog should retain that configuration.

promlog initialized its go-kit logger to use UTC timestamps, so for true
backwards compatibility, the go-kit log style in promslog should retain
that configuration.

Signed-off-by: Daniel Swarbrick <[email protected]>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also do this for normal slog logging as well. We have a UTC policy for logging because we have a UTC policy for the metrics store in the TSDB.

This make sure we always get aligned time when comparing Prometheus logs and metrics.

@SuperQ SuperQ merged commit d66e745 into prometheus:main Sep 20, 2024
7 checks passed
@dswarbrick dswarbrick deleted the go-kit-utc branch September 20, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants