Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Job.ReclaimablePods for AppWrappers #51

Open
dgrove-oss opened this issue Mar 12, 2024 · 3 comments
Open

implement Job.ReclaimablePods for AppWrappers #51

dgrove-oss opened this issue Mar 12, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@dgrove-oss
Copy link
Collaborator

In the cases where the appwrapper contains resources that are managed by Kueue and the component implemented ReclaimablePods, we should monitor the workload instances and flow that information through to Kueue.

@dgrove-oss dgrove-oss added the enhancement New feature or request label Mar 12, 2024
@dgrove-oss
Copy link
Collaborator Author

dgrove-oss commented Jun 7, 2024

This is somewhat related to #74 in that it also relies on fairly detailed understanding of the wrapped GVK's semantics.

@dgrove-oss
Copy link
Collaborator Author

In Kueue 0.7 only Job, JobSet, and Pod (for PodGroups) implement this optional interface. Until the interface is more widely adopted, there is limited value to recognizing this situation and flowing it through the AppWrapper to Kueue.

@tardieu
Copy link
Member

tardieu commented Sep 11, 2024

While support for Ray jobs seems problematic given #174, we should be able to implement this interface for wrapped PyTorchJobs, in the following sense: if a PyTorchJob status is failed then we can assume no more pods will be created by the Training operator for this job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants