Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading the full app through the stub fails #15

Open
binarynoise opened this issue Sep 30, 2022 · 1 comment
Open

Downloading the full app through the stub fails #15

binarynoise opened this issue Sep 30, 2022 · 1 comment

Comments

@binarynoise
Copy link
Collaborator

There is a problem when you hide the Manager and want to use it from a secondary user. Only the stub gets installed for him and the stub prompts the user to download the full app, so it can load it and show the Manager. That fails.
In logcat we find java.io.FileNotFoundException: https://cdn.jsdelivr.net/gh/topjohnwu/[email protected]/app-release.apk

In https://github.com/programminghoch10/Lygisk/blob/master/stub/build.gradle.kts#L17 there is a link to some Magisk APK, getting the correct version by looking at https://github.com/programminghoch10/Lygisk/blob/master/config.prop.sample#L7 which we don't override, so the lookup fails as the file does not exist because the correct version would be v25.2 instead of v25.200.

@programminghoch10
Copy link
Owner

Fixing the version code and querying https://cdn.jsdelivr.net/gh/topjohnwu/magisk-files@${Config.version}/app-release.apk would yield nothing, as the original Magisk app would be downloaded, which has the wrong signature and doesn't have our addond install fixes.
We might be able to replace the url to match it to our deploy framework:
https://raw.githubusercontent.com/programminghoch10/Lygisk/deploy/stable/app-release.apk
Though I'd rather kill stub completely. Everywhere it is used we might as well place the complete manager, why is stub even needed anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants