Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash has auto styling that interfere with SVG elements #3020

Open
liranelisha opened this issue Mar 13, 2023 · 11 comments
Open

Flash has auto styling that interfere with SVG elements #3020

liranelisha opened this issue Mar 13, 2023 · 11 comments
Assignees
Labels

Comments

@liranelisha
Copy link

liranelisha commented Mar 13, 2023

Description

I am writing to report an issue with a Flash component that I have been using on my website. The component appears to have an auto-styling feature that is interfering with the SVG elements on my web pages.

Specifically, the auto-styling feature is causing the SVG elements to be displayed incorrectly with fixed marginRight of 2 (8px). This is an issue, as the SVG elements are a part of the design and functionality of my pages.

I have tried adjusting the CSS styles for the SVG elements to no avail, as the auto-styling seems to get a priority. The only way to resolve the issue seems to be to add the !important.

I would greatly appreciate it if you could look into this issue and provide a solution as soon as possible. If necessary, I can provide you with access to my website and the code for the Flash component and the SVG elements.

Thank you for your prompt attention to this matter.

image

Steps to reproduce

create a StyledOcticon inside a Flash component

Version

35.21.0

Browser

No response

@liranelisha liranelisha added the bug Something isn't working label Mar 13, 2023
@dejnon
Copy link

dejnon commented Mar 13, 2023

Here is another reproduction:
image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2023
@liranelisha
Copy link
Author

this issue was seen in the devportal
example: https://devportal.githubapp.com/devportal/apps/github?tab=deployments
when we have the "external link" icon when the text include a link to external source

@lesliecdubs lesliecdubs reopened this Oct 17, 2023
@github-actions github-actions bot removed the Stale label Oct 17, 2023
@lesliecdubs
Copy link
Member

Thanks for the report, this does seem to be a bug.

Internal note: I am removing the react label from this issue for now so that Primer Design can hopefully prioritize this. @tallys let us know if that's not doable.

@tallys
Copy link

tallys commented Oct 24, 2023

@lukasoppermann let's take a look at this as part of our work on flash/banner

@lukasoppermann
Copy link
Contributor

Yes. 👍

Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 21, 2024
@liranelisha
Copy link
Author

liranelisha commented Apr 24, 2024

sill happening... any updates @lukasoppermann ?

@lukasoppermann
Copy link
Contributor

lukasoppermann commented Apr 24, 2024

@liranelisha we will keep this in mind for the new component.

CC: @JoseInTheArena should we add the react to make sure it is address in #4335 ?

@lukasoppermann
Copy link
Contributor

@liranelisha could you verify that the issue is fixed in the new component?

https://primer.style/components/banner/react/draft

@liranelisha
Copy link
Author

i think we are currently unable to upgrade to version 36.27.0 as it cause some unit testing fails on our side. but i'll keep on my list to test it and reopen if needed once upgraded

@jonrohan jonrohan self-assigned this Nov 1, 2024
@lukasoppermann lukasoppermann removed their assignment Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants