Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding rule to check for old css variables and replace with v8 #116

Merged
merged 12 commits into from
Nov 29, 2023
Merged

Adding rule to check for old css variables and replace with v8 #116

merged 12 commits into from
Nov 29, 2023

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Nov 16, 2023 •
edited
Loading

Adding rule to check for old css variables and replace with v8

Currently not working are templateElements

Issues

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 090b2ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasoppermann lukasoppermann marked this pull request as ready for review November 29, 2023 12:56
@lukasoppermann lukasoppermann requested a review from a team November 29, 2023 12:56
langermank
langermank approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dotcom, appears to be doing what we want! THANK YOU!

joshblack
joshblack approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Amazing work on this 🔥

src/rules/new-color-css-vars.js Outdated Show resolved Hide resolved
@langermank langermank merged commit 7f4c467 into main Nov 29, 2023
5 checks passed
@langermank langermank deleted the @lukasoppermann/v8-color-token-rule branch November 29, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@joshblack joshblack joshblack approved these changes

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasoppermann @joshblack @langermank