Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleButton: aria-label removed from ToggleButton #6976

Closed
LanFeusT23 opened this issue Dec 18, 2024 · 0 comments
Closed

ToggleButton: aria-label removed from ToggleButton #6976

LanFeusT23 opened this issue Dec 18, 2024 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@LanFeusT23
Copy link
Contributor

Describe the bug

Adding an aria-label to a ToggleButton component does not result in it being added in the html:

    <ToggleButton
      v-model="checked"
      class="w-24"
      onLabel="On"
      offLabel="Off"
      aria-label="This Aria label is not added to the button"
    />

renders:

<button type="button" class="p-togglebutton p-component w-24" aria-pressed="false" data-pc-name="togglebutton" pc6="" data-pc-section="root" data-p-checked="false" data-p-disabled="false"><span class="p-togglebutton-content" data-pc-section="content"><!----><span class="p-togglebutton-label" data-pc-section="label">Off</span></span></button>

Reproducer

https://stackblitz.com/edit/j9yfme6g?file=src%2FApp.vue

PrimeVue version

4.2.5

Vue version

4.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

All

Steps to reproduce the behavior

  1. Make use of a ToggleButton component
  2. Add an aria-label for example aria-label="test 123"
    => the arial-label is not rendered in the html

Expected behavior

The aria-label should not be removed from the button

@LanFeusT23 LanFeusT23 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 18, 2024
@LanFeusT23 LanFeusT23 changed the title Component Name: aria-label removed from ToggleButton ToggleButton: aria-label removed from ToggleButton Dec 19, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 20, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.2.6 milestone Dec 20, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Dec 20, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 20, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeVue Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

2 participants