-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password input with reactive form, eyeball icon initially outside box until clicked #10788
Comments
I confirm, have this bug too |
I confirm, same problem |
Here is a workaround that appears to work, but it is not very nice... as it accesses the private 'cd' member in the password component. ` @ViewChild(Password) passwordComponent: Password; ngAfterViewInit() { |
as a workaround, you can use
|
I have the same problem, happening in 13.0.2 too. |
Seems like [ngCLass] is not working with reactive form. Another UGLY workaround is: |
|
<p-password formControlName="password" [toggleMask]="true" styleClass="p-password p-component p-inputwrapper p-input-icon-right"> Worked for me |
Issue still exists on version 13.1.0 |
I have the same issue on version 12.2.0 |
I confirm. |
any official fixes? |
Issue still exists on version 13.2.0. Found something interesting I guess. So i went to their changelog, and found following addition in 12.2.1:
Maybe this one will help to figure out the problem. |
I have the same problem but in the version "primeng": "^13.0.4"
Workaround => styleClass="p-password p-component p-inputwrapper p-input-icon-right" works |
I confirm the issue still exist in the version "13.3.2" :( |
I confirm the issue still exist in the version "13.1.0". And this workaround is usefull, but i'm added to this styles "w-full", it's work.
|
On version 13.3.3 I had the same problem. Solved using
Thanks for raising the issue. |
Can confirm still exists in 13.4.1 |
I have the same problem but in the version "primeng": "^13.0.4" @omaihuru <p-password [feedback]="false" [toggleMask]="true" formControlName="password" id="password" styleClass="p-password p-component p-inputwrapper p-input-icon-right"> Workaround => styleClass="p-password p-component p-inputwrapper p-input-icon-right" works for me Thanks for raising the issue. |
Still an issue. Would be nice to not have to use one of these workarounds. |
Maybe it https://github.com/primefaces/primeng/pull/11416/files fix them also |
How did you discover that it was solved like this, it worked perfectly for me, thanks. |
Hi, So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap? Best Regards, |
Tested on version 14.2.1. |
Thanks, this worked for me |
Thank you, it worked for me |
My situation was that I started with an old project that used PrimeNG
I generated a random theme and saw that the selector was different:
So I added the new selector to the old |
Hi @Ban117, In my case was exactly the same thing. With a little difference, I completely replaced all files from "asstes/styles/theme" with their, so that css was/is like that on on their own css files. I downloaded version 16.0.0. |
[x ] bug report => Search github for a similar issue or PR before submitting
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.
https://stackblitz.com/edit/angular-bdvuuo-ypaemo?file=src/app/app.component.html
Current behavior
Use p-password with a reactive form control
<p-password [formControl]="pwFormControl" [toggleMask]="true" [feedback]="false"></p-password>
The eyeball will be positioned outside the input box. Clicking inside the input box resizes it and applies classes and makes it look correct.
Expected behavior
Eyeball should be positioned correctly
Minimal reproduction of the problem with instructions
See stackblitz
https://stackblitz.com/edit/angular-bdvuuo-ypaemo?file=src/app/app.component.html
Angular version: 12.2.7
PrimeNG version: 12.2.1
This does NOT happen in 12.2.0, only in 12.2.1
The text was updated successfully, but these errors were encountered: