Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 scrubbing #2981

Closed
VeronikaSolovei9 opened this issue Jul 27, 2023 · 2 comments
Closed

IPv6 scrubbing #2981

VeronikaSolovei9 opened this issue Jul 27, 2023 · 2 comments
Labels

Comments

@VeronikaSolovei9
Copy link
Contributor

In PBS Java here is a function to scrub IpV6: https://github.com/prebid/prebid-server-java/blob/3ebefb8ccdb52e68bb604660fc9808b54a513536/src/main/java/org/prebid/server/auction/IpAddressHelper.java#L39
and here is a simple unit tests for it: https://github.com/prebid/prebid-server-java/blob/3ebefb8ccdb52e68bb604660fc9808b54a513536/src/test/java/org/prebid/server/auction/IpAddressHelperTest.java#L65

It works a little different from what we have in Go.
Go:
For the Ip = "1111:2222:3333:4444:5555:6666:7777:8888" func scrubIPV6Lowest32Bits will return "1111:2222:3333:4444:5555:6666:0:0". It makes sense, lowest 32 bits were changed to 0s.
Java:
For the Ip = "1111:2222:3333:4444:5555:6666:7777:8888" result is "1111:2222:3333:4400::"

In Ipv6 lowest 64 bits represent physical or device Mac address and upper 64 bits represent a network address.
Upper 48 bits represent global address and next 16 bits represent subnet id.
http://www.steves-internet-guide.com/ipv6-guide/
https://en.wikipedia.org/wiki/IPv6_address
It looks like PBS Java only leaves a global address and scrub a half of subnet id and device Mac address.

@VeronikaSolovei9 VeronikaSolovei9 changed the title IPv6 scrubbing in PBS-Go IPv6 scrubbing Jul 27, 2023
@SyntaxNode
Copy link
Contributor

Discovered during unification of privacy enforcement rules. Looks like we missed this a while back. Placed on the PBS-Go's priority item list.

@bretg bretg moved this from Triage to Ready for Dev in Prebid Server Prioritization Jul 28, 2023
@hhhjort
Copy link
Collaborator

hhhjort commented Sep 6, 2023

PR has merged

@hhhjort hhhjort closed this as completed Sep 6, 2023
@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid Server Prioritization Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants