Implementation Plan For Seat Non Bid Status Codes

[ShriprasadM]

Following is the list of some seat non-bid error codes as per IAB community extension. I am working on mapping of other remaining error codes.
But, by that time @SyntaxNode , @bretg , @bsardo please review following table and confirm if locations mentioned under PBS Source Code column are correct for capturing seat non bid scenarios.

SEAT NON BID ERROR CODE	PBS Source Code
100 (Error - General)per bidder	prebid-server/exchange/bidder.go Line 137 in 79422a7 if len(reqData) == 0 { prebid-server/exchange/bidder.go Line 534 in 79422a7 err = &errortypes.Timeout{Message: err.Error()} The adapter failed to generate any bid requests, but also failed to generate an error explaining why.
101(Error - Timeout)per bidder	prebid-server/exchange/bidder.go Line 137 in 79422a7 if len(reqData) == 0 { prebid-server/exchange/bidder.go Line 534 in 79422a7 err = &errortypes.Timeout{Message: err.Error()} bidder.doRequestImpl
102 (Error - Invalid Bid Response)per bidder	prebid-server/exchange/bidder.go Line 565 in 79422a7 if httpResp.StatusCode < 200 || httpResp.StatusCode >= 400 { bidder.doRequestImpl
103 (Error - Bidder Unreachable)per bidder	https://github.com/prebid/prebid-server/blob/79422a7542634b356f9c13d7774117f2b818e996/exchange/bidder.go#L565bidder.doRequestImpl  if httpStatusCode = 503
201 (Request Blocked - Unsupported Channel (app/site/dooh))per bidder	prebid-server/adapters/infoawarebidder.go Line 40 in 79422a7 return nil, []error{&errortypes.Warning{Message: "this bidder does not support site requests"}} prebid-server/adapters/infoawarebidder.go Line 46 in 79422a7 return nil, []error{&errortypes.Warning{Message: "this bidder does not support app requests"}}
202 (Request Blocked - Unsupported Media Type (banner/video/native/audio))	prebid-server/adapters/infoawarebidder.go Line 60 in 79422a7 return nil, append(errs, &errortypes.Warning{Message: "Bid request didn't contain media types supported by the bidder"})
203 (Request Blocked - Optimized)
204 (Request Blocked - Privacy)	https://github.com/prebid/prebid-server/blob/79422a7542634b356f9c13d7774117f2b818e996/exchange/utils.go#L170GDPR request blocked
301 (Response Rejected - Below Floor)	prebid-server/exchange/exchange.go Line 388 in 79422a7 errs = append(errs, &errortypes.Warning{
304 (Response Rejected - Below Deal Floor)	TBD

[hhhjort]

In exchange/bidder.go, I would say line 137 maps best to 100 (General) and line 534 to 101 (Timeout). Line 565 is correct as 102 (Invalid response).

The infoawarebidder.go errors all look correct.

The exchange/utils.go line looks correct, but will be refactored for the upcoming privacy framework.

The exchange/exchange.go is correct.

I have not had time to go through the code to verify if there are any other areas where bids may be rejected.

[ShriprasadM]

Thanks @hhhjort for an update. Can you review 103 (Error - Bidder Unreachable)per bidder

[hhhjort]

Oh, sorry, missed that one. 103 seems reasonable for a 503 error code.

[bretg]

Are we good here @ShriprasadM ?

[ShriprasadM]

@bretg : I have started on some error codes. I am facing few challenges while implementing. How to obtain impId in bidder.go.

reqData, errs = bidder.Bidder.MakeRequests(bidderRequest.BidRequest, reqInfo)

how can we determine if array of reqData contains separate req per impression or on single request contains multi impression objects?

[bretg]

Closing this issue as covered by the new issue #2973

[ShriprasadM]

@bretg : Can we reopen this issue ? I had created this issue to add all seat non bid error codes mentioned here - https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/extensions/community_extensions/seat-non-bid.md#list-non-bid-status-codes
The current PR only addressing timeout related error code

[SyntaxNode]

Re-opening. This issue is a discussion on how to implement non bid status codes in PBS-Go. This is separate and disinct from #2973 which solves a specific problem of attributing network failures to impression ids.

[ashishshinde-pubm]

Sr No	SEAT NON BID ERROR CODE	PBS Source Code
1	351: Response Rejected - Invalid Creative (Size Not Allowed)	prebid-server/exchange/exchange.go Line 1226 in 79422a7 if !e.validateBannerCreativeSize(bid, bidResponseExt, adapter, pubID, e.bidValidationEnforcement.BannerCreativeMaxSize) {
2	352: Response Rejected - Invalid Creative (Not Secure)	prebid-server/exchange/exchange.go Line 1234 in 79422a7 if !e.validateBidAdM(bid, bidResponseExt, adapter, pubID, e.bidValidationEnforcement.SecureMarkup) {
3	350: Response Rejected - Invalid Creative	prebid-server/modules/prebid/ortb2blocking/hook_raw_bidder_response.go Line 72 in 79422a7 } else {
4	300- Response Rejected - General	prebid-server/exchange/bidder_validate_bids.go Line 63 in 79422a7 errs = append(errs, berr)
5	300: Response Rejected - General	prebid-server/exchange/bidder.go Line 329 in 79422a7 continue
6	100-Error - General	prebid-server/exchange/bidder.go Line 373 in 79422a7 errs = append(errs, err)

[ashishshinde-pubm]

@SyntaxNode , @bretg , @bsardo please review above table and confirm if locations mentioned under PBS Source Code column are correct for capturing seat non bid scenarios.

For point (3) in above table, we have few queries regarding ortb2blocking module.

1. What if one creative gets rejected with multiple reasons (example - if same bid is rejected due to both bcat and badv) then should we log multiple reasons in seat-non-bid ? if we have to log single record then which one to prioritise? Do you think adding errmessage in non-bid structure would be helpful and can handle such use-cases by providing granular information ?

2. Implementation approach - How module should report non-bids rejected in module to PBS source code ?
   2.1 Introduce seatNonBids under HookOutcome ?
   2.2 Use hookanalytics.Analytics present in HookOutcome ? --> we might need to ask module developer to return rejected bids using specific Activity.Name
   2.3 How to handle the case, where same bid can get rejected in multiple modules due to different reasons ? Should we add multiple records in seat-non-bid ? if not then which one to prioritise ?

[bretg]

Should we add multiple records in seat-non-bid ? if not then which one to prioritise ?

If there are multiple reasons, pick one -- any one. The idea is that someone will fix one of the issues and then the next one will appear.

If you're looking for an algorithm to pick, then we would suggest choosing the lowest numbered seatnonbid code.

[bsardo]

Hi @ashishshinde-pubm, I agree with all of the locations for capturing the specified non bid error codes except for (3) where you’re proposing we return 350 when the ortb2blocking module detects an error in the raw bidder response hook. Instead, I think we may want to return 356 (Response Rejected - Invalid Creative - Advertiser Blocked) if the ortb2blocking module config was loaded from the account config and 350 (Response Rejected - Invalid Creative) if the config was loaded from the host config. Thoughts?

[ashishshinde-pubm]

Hi @bsardo ,
For point (3) the bid may get rejected due to any reason (badv/bcat/cattax/battr) that's why I was thinking to provide the generic NBR (350 (Response Rejected - Invalid Creative)).
Do you see any difference between config loaded from account-config vs config loaded from host-config ?

[ashishshinde-pubm]

As discussed in the bi-weekly meeting, we should return code 356 (Response Rejected - Invalid Creative - Advertiser Blocked) if bid gets rejected due to "badv" field.
For other rejection due to bcat/cattax/battr, we can return generic code 350 (Response Rejected - Invalid Creative).

[bsardo]

As discussed, we also should not care whether the config was loaded from the host or the account as I had originally mentioned. The behavior should be same in both cases.

[bretg]

@ShriprasadM , @bsardo - is the "plan" part of this done? I thought we were well into implementation at this point?

[bretg]

@ShriprasadM - are we good here? If the PR's pretty much done, perhaps the tracking issue can be closed out?