feat: avoid fatal error

[alexander-akait]

/cc @ludofischer @Semigradsky

The main idea is avoid fatal error when we can't parse and keep value as it, should we use warning or error? Should we have options to change warning on error and versa vice.

[ludofischer]

The main idea is avoid fatal error when we can't parse and keep value as it, should we use warning or error? Should we have options to change warning on error and versa vice.

In the context of cssnano I think it should be a warning, if the code reaches minification we assume the CSS is already tested and validated. There's already a way to turn PostCSS warnings into errors, and I don't think adding the option to one plugin at a time is a common use case (why would you want to only error when there are calc() warnings but not on other warnings?)

[alexander-akait]

why would you want to only error when there are calc() warnings but not on other warnings?

Because here he handle only calc 😄

Right now many developers get fatal errors due this using cssnano, we should fix it

[ludofischer]

I think this is fine, people can use a linter to prevent them from writing invalid CSS.

[alexander-akait]

@ludofischer anyway we should use postcss API for errors, no just throw an error

[ludofischer]

@ludofischer anyway we should use postcss API for errors, no just throw an error

Yes, this should solve cssnano/cssnano#910

[ludofischer]

Is this ready? I've received permissions on this repository so I could merge it.

[alexander-akait]

Ready, just want to ensure you review my changes

[ludofischer]

Looks fine, we can fix the quote formatting in a different PR as right now it's inconsistent throughout the code base.

[alexander-akait]

do you have access for publish?

[ludofischer]

do you have access for publish?

No.

[alexander-akait]

@ludofischer Sorry for delay, added permission for postcss-calc, now you can publish