Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics not fully disabled #3685

Open
strengejacke opened this issue Jun 28, 2024 · 3 comments
Open

Diagnostics not fully disabled #3685

strengejacke opened this issue Jun 28, 2024 · 3 comments
Labels
area: diagnostics Issues related to Diagnostics area: kernels Issues related to Jupyter kernels and LSP servers bug Something isn't working lang: r support

Comments

@strengejacke
Copy link

strengejacke commented Jun 28, 2024

When I disable diagnostics ("positron.r.diagnostics.enable": false), it takes immediately effect. However, after re-starting Positron, I get diagnostics warnings for some code lines, but not for all. But why do I get the diagnostics at all?

This code line is marked:

image

Others (in the same file and function) are not (as expected, because diagnostics are disabled)

image

@strengejacke strengejacke added the bug Something isn't working label Jun 28, 2024
@strengejacke
Copy link
Author

I guess the second isn't highlighted because it's a function call inside a function (i.e. used as argument). Anyway, disabling diagnostics does not have the desired effect.

@lionel- lionel- added lang: r area: kernels Issues related to Jupyter kernels and LSP servers area: diagnostics Issues related to Diagnostics labels Jun 30, 2024
@DavisVaughan
Copy link
Contributor

DavisVaughan commented Jul 1, 2024

I think that on startup we aren't getting a refresh of the "positron.r.diagnostics.enable" configuration variable, so we assume true.

We probably need a refresh of all global config in initialized(), or a refresh of all config (document + global) in did_open().

Screen.Recording.2024-07-01.at.7.46.46.AM.mov

@strengejacke
Copy link
Author

Whenever you run a command or enter something in the console, like x <- 1, diagnostics are disabled (i.e. the setting is realized).

@juliasilge juliasilge added this to the Release Candidate milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: diagnostics Issues related to Diagnostics area: kernels Issues related to Jupyter kernels and LSP servers bug Something isn't working lang: r support
Projects
None yet
Development

No branches or pull requests

4 participants