From 9fb49b4a3159a897278f8514164795c526cebc1a Mon Sep 17 00:00:00 2001
From: Marie Idleman <marie.idleman@posit.co>
Date: Fri, 13 Dec 2024 13:50:57 -0600
Subject: [PATCH] actually use the envs

---
 .github/workflows/test-e2e-linux.yml   | 10 +++++-----
 .github/workflows/test-e2e-windows.yml | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/test-e2e-linux.yml b/.github/workflows/test-e2e-linux.yml
index f559678e93a..0fc513d2139 100644
--- a/.github/workflows/test-e2e-linux.yml
+++ b/.github/workflows/test-e2e-linux.yml
@@ -30,7 +30,7 @@ on:
         type: string
       report_testrail:
         required: false
-        description: "Whether or not to report results to Test Rail."
+        description: "Whether or not to report results to TestRail."
         default: false
         type: boolean
 
@@ -131,17 +131,17 @@ jobs:
           report-dir: ${{ env.REPORT_DIR }}
 
       - name: Install trcli
-        if: ${{ inputs.report_testrail }}
+        # if: ${{ inputs.report_testrail == 'true' }}
         shell: bash
         run: sudo apt-get update && sudo apt-get install -y python3-pip && pip3 install trcli
 
       - name: Upload Test Results to TestRail
-        if: ${{ inputs.report_testrail }}
+        # if: ${{ inputs.report_testrail == 'true' }}
         shell: bash
         run: |
-          TESTRAIL_TITLE="$(date +'%Y-%m-%d') ${{ inputs.testrail-title }} - $GITHUB_REF_NAME"
+          TESTRAIL_TITLE="$(date +'%Y-%m-%d') ${{ env.TESTRAIL_TITLE }} - $GITHUB_REF_NAME"
           echo "TESTRAIL_TITLE=$TESTRAIL_TITLE" >> $GITHUB_ENV
-          trcli --host "https://posit.testrail.io/" --project "${{ inputs.testrail-project }}" --username testrailautomation@posit.co --key "${{ inputs.testrail-api-key }}" parse_junit --file "./junit.xml" --case-matcher name --title "$TESTRAIL_TITLE" --close-run
+          trcli --host "https://posit.testrail.io/" --project "${{ env.TESTRAIL_PROJECT }}" --username testrailautomation@posit.co --key "${{ env.TESTRAIL_API_KEY }}" parse_junit --file "./junit.xml" --case-matcher name --title "$TESTRAIL_TITLE" --close-run
         env:
           TESTRAIL_TITLE: ${{ inputs.project }}
           TESTRAIL_PROJECT: "Positron"
diff --git a/.github/workflows/test-e2e-windows.yml b/.github/workflows/test-e2e-windows.yml
index 0bea7f5b9e1..48cea3ce9bf 100644
--- a/.github/workflows/test-e2e-windows.yml
+++ b/.github/workflows/test-e2e-windows.yml
@@ -24,7 +24,7 @@ on:
         type: string
       report_testrail:
           required: false
-          description: "Whether or not to report results to Test Rail."
+          description: "Whether or not to report results to TestRail."
           default: false
           type: boolean
 
@@ -169,17 +169,17 @@ jobs:
           report-dir: ${{ env.REPORT_DIR }}
 
       - name: Install trcli
-        if: ${{ inputs.report_testrail }}
+        # if: ${{ inputs.report_testrail == 'true' }}
         shell: bash
         run: sudo apt-get update && sudo apt-get install -y python3-pip && pip3 install trcli
 
       - name: Upload Test Results to TestRail
-        if: ${{ inputs.report_testrail }}
+        # if: ${{ inputs.report_testrail == 'true' }}
         shell: bash
         run: |
-          TESTRAIL_TITLE="$(date +'%Y-%m-%d') ${{ inputs.testrail-title }} - $GITHUB_REF_NAME"
+          TESTRAIL_TITLE="$(date +'%Y-%m-%d') ${{ env.TESTRAIL_TITLE }} - $GITHUB_REF_NAME"
           echo "TESTRAIL_TITLE=$TESTRAIL_TITLE" >> $GITHUB_ENV
-          trcli --host "https://posit.testrail.io/" --project "${{ inputs.testrail-project }}" --username testrailautomation@posit.co --key "${{ inputs.testrail-api-key }}" parse_junit --file "./junit.xml" --case-matcher name --title "$TESTRAIL_TITLE" --close-run
+          trcli --host "https://posit.testrail.io/" --project "${{ env.TESTRAIL_PROJECT }}" --username testrailautomation@posit.co --key "${{ env.TESTRAIL_API_KEY }}" parse_junit --file "./junit.xml" --case-matcher name --title "$TESTRAIL_TITLE" --close-run
         env:
           TESTRAIL_TITLE: "e2e-windows"
           TESTRAIL_PROJECT: "Positron"