You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm writing a wrapper function for gt.fmt_datetime, gt.fmt_date etc. but I need to import DateStyle and TimeStyle from great_tables._formats to type hint the function correctly.
Have you considered re-exporting these Literals so they are accessible from the public API? Happy to make the PR myself, as well as re-export any other type hints that are in the public API if you agree this should be done.
The text was updated successfully, but these errors were encountered:
@machow and @rich-iannone, do you think we should consider exposing some literals to make it easier for users to adopt type hints?
In the meantime, this could be a good opportunity to reflect on how we might enhance our type hints. I understand that the linter struggles with interpreting our databackend logic, and ensuring smooth compatibility with mypy remains a significant challenge for us.
Hi, thanks for the great library!
I'm writing a wrapper function for
gt.fmt_datetime
,gt.fmt_date
etc. but I need to importDateStyle
andTimeStyle
fromgreat_tables._formats
to type hint the function correctly.Have you considered re-exporting these Literals so they are accessible from the public API? Happy to make the PR myself, as well as re-export any other type hints that are in the public API if you agree this should be done.
The text was updated successfully, but these errors were encountered: