feat(ismp-grandpa): add benchmarking support #353
+128
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add WeightInfo trait and default implementation - Integrate benchmarking feature flag and dependencies - Configure benchmarking in Gargantua and Nexus runtimes - Add placeholder weight values for pallet extrinsics This implements benchmarking support for ismp-grandpa, addressing polytope-labs#350.
sylvaincormier
force-pushed
the
feat/benchmark-ismp-grandpa
branch
from
8507b80 to
15664bb
Compare
seunlanlege
reviewed
Dec 16, 2024
| use super::*; | ||
|
|
||
| #[benchmark] | ||
| fn add_state_machines() -> Result<(), BenchmarkError> { |
There was a problem hiding this comment.
shouldn't this benchmark be dynamic? so that the weight is calculated based on the number of items to be added?
seunlanlege
reviewed
Dec 16, 2024
| } | ||
|
|
||
| #[benchmark] | ||
| fn remove_state_machines() -> Result<(), BenchmarkError> { |
seunlanlege
reviewed
Dec 16, 2024
Comment on lines
+30
to
+31
| fn add_state_machines() -> Weight; | ||
| fn remove_state_machines() -> Weight; |
There was a problem hiding this comment.
should take the length of state machines
seunlanlege
reviewed
Dec 16, 2024
| @@ -41,6 +51,7 @@ pub mod pallet { | |||
|
|
|||
| /// IsmpHost implementation | |||
| type IsmpHost: IsmpHost + Default; | |||
| type WeightInfo: WeightInfo; | |||
There was a problem hiding this comment.
Some doc comments will be nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements benchmarking support for
ismp-grandpa, addressing issue #350. The implementation includes:WeightInfotrait and default weight implementationChanges include
Related issues
Closes #350
Testing Instructions
cargo test -p ismp-grandpa --features runtime-benchmarks