fix(gas-oracle): handle Optimism Ecotone blob fees #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add OptimismGasComponents struct to track L1/L2 fees - Implement proper L1 data posting cost calculation - Consider both base fee and blob fee with scalars - Fix gas price overestimation issue Fixes polytope-labs#336
|
Thanks for this. In the code comments where the gas price calculations are implemented, please add relevant links to the OpStack repo. |
Wizdave97
requested changes
Dec 16, 2024
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_optimism_total_gas_calculation() { |
There was a problem hiding this comment.
It would be much better to test this using OpSepolia directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes gas price overestimation issue in the Optimism gas oracle following the Ecotone upgrade which introduced blob fees.
Changes
Testing
Impact
This fix ensures accurate gas estimations for Optimism transactions by properly accounting for:
Fixes #336