Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update members’ permissions for key Fellowship repos #11

Open
anaelleltd opened this issue Nov 18, 2024 · 6 comments
Open

Update members’ permissions for key Fellowship repos #11

anaelleltd opened this issue Nov 18, 2024 · 6 comments

Comments

@anaelleltd
Copy link

anaelleltd commented Nov 18, 2024

To help onboard candidates and engage new members as Fellowship contributors, Kian suggested a couple of months ago that we provide certain access rights for all existing members in the Runtimes repo.

Earlier on, Bryan had recommended that we give basic labelling rights to members/contributors for tracking the implementation of all approved PRs in the RFCs repo.

These new setups could be implemented through the existing Fellowship automation system.

I have summarised what these changes could look like in the table below:

Repos Permissions Rank 1 Rank 2 Rank 3+
Runtimes Create projects N Y Y
- Create/delete labels N Y Y
- Add/remove labels Y Y Y
- Assign PRs/issues Y Y Y
- Review PRs (for approval) Y Y Y
- Merge PRs N N Y
- Trigger releases ? ? Y
- Close PRs/issues N N Y
- - - - -
RFCs Create projects N Y Y
- Add/remove labels Y Y Y
- Assign PRs/issues Y Y Y
- Merge PRs (on-chain only) N N Y
- Close PRs/issues N ? Y
- - - - -

Please check if this makes sense from a top-down perspective. Your advice is needed on how we should proceed where there is a ?.

@kianenigma
Copy link

I agree that Merge PRs should be only for Rank 3+.

Ideally, triggering a release should also only be Rank 3+, or even 4+.

Rest LGTM

@anaelleltd
Copy link
Author

I agree that Merge PRs should be only for Rank 3+.

Thank you! I have updated the table accordingly.

@bkchr
Copy link

bkchr commented Nov 20, 2024

Reviews in general are permissionless. So anyone can do them, maybe rename it to "do they count for approvals"?

For the RFCs, merge rights should be only via the on chain process.

@anaelleltd
Copy link
Author

anaelleltd commented Nov 20, 2024

Reviews in general are permissionless. So anyone can do them, maybe rename it to "do they count for approvals"?

I have done this, thanks.

For the RFCs, merge rights should be only via the on chain process.

I have specified this. Thank you!

@anaelleltd
Copy link
Author

@Bullrich Are you or your team available to implement these suggested changes? 👀

@Bullrich
Copy link

Hi @anaelleltd, I no longer work in Parity.

Try contacting @lovelaced, she may be able to guide you in the correct direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants