Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Imports example does not represent the style guide #17

Open
5c077yP opened this issue Aug 5, 2013 · 0 comments
Open

Module Imports example does not represent the style guide #17

5c077yP opened this issue Aug 5, 2013 · 0 comments

Comments

@5c077yP
Copy link

5c077yP commented Aug 5, 2013

Hey in the section Module Imports it's mentioned to order your imports by:

  1. Standard library imports (if a standard library exists)
  2. Third party library imports
  3. Local imports (imports specific to this application or library)

in the example it's written:
require 'lib/setup'
Backbone = require 'backbone'

But isn't "require 'lib/setup'" a local import and "Backbone = require 'backbone'" a third-party library? If this is correct one should switch the order in the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant