Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System cannot find the file specified(mpv.net + uosc) #47

Closed
DonBureq opened this issue Oct 20, 2022 · 5 comments
Closed

System cannot find the file specified(mpv.net + uosc) #47

DonBureq opened this issue Oct 20, 2022 · 5 comments

Comments

@DonBureq
Copy link

DonBureq commented Oct 20, 2022

Hello
I have a problem with thumbfast script on Mpv.net(windows) using uosc OSC. The thumbnails are not showing at all and the console is showing "System cannot find the file specified" errors every time i hover cursor over the seek bar. I've checked the regular mpv and both scripts works without problems. I have also tried to run mpv.net with default settings but it didn't help much.
Thanks
image

@dyphire
Copy link
Contributor

dyphire commented Oct 21, 2022

This is because the script only works for mpv, which needs on using mpv commands in subprocesses.

thumbfast/thumbfast.lua

Lines 253 to 255 in eb21b2e

mp.command_native_async(
{name = "subprocess", playback_only = true, args = {
"mpv", path, "--no-config", "--msg-level=all=no", "--idle", "--pause", "--keep-open=always", "--really-quiet", "--no-terminal",

Unfortunately, mpv.net is based on libmpv(mpv-2.dll), so it cannot use the mpv commands in subprocesses.
If you really want to use this script with mpvnet, you have to add mpv to PATH first.

Relevant: mpvnet-player/mpv.net#262, marzzzello/mpv_thumbnail_script#2

@DonBureq
Copy link
Author

HI. Thanks for your help. I can confirm that adding mpv to PATH variable fixed the problem. Closing

@megapro17
Copy link

wtf, is running two different player efficient?

@po5
Copy link
Owner

po5 commented Nov 19, 2022

If you're asking in the context of mpv.net+regular mpv, it's not any less efficient than the script's normal operation.

If it's the normal operation of running a background instance to generate thumbnails you're asking about, it's a minor memory usage increase over not having the bg instance, with the benefit that generating a new thumbnail is fast (and cheap thanks to your OS's disk access cache).
It's better than the alternative of heavy pre-generating of every thumbnail, and lets us have frame-accurate thumbnails for where you'll end up after seeking.

@megapro17
Copy link

If you're asking in the context of mpv.net+regular mpv, it's not any less efficient than the script's normal operation.

thanks, this is what i wanted to know. i even enabled luajit so i guess it will be more efficent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants