You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most three-stdlib controllers like OrbitControls and others are incompatible with R3F controls API.
This is because R3F store controls: THREE.EventDispatcher | null (source) extends from THREE.EventDispatcher, but latest three-stdlib introduced its own EventDispatcher (pmndrs/three-stdlib#388) and their types do not match.
How to reproduce: Using latest R3F and three-stdlib write this line of code: useThree().set({controls: OrbitControls}) Expected: Typescript should not complain. Currently: TS complains.
Most
three-stdlib
controllers likeOrbitControls
and others are incompatible with R3F controls API.This is because R3F store
controls: THREE.EventDispatcher | null
(source) extends fromTHREE.EventDispatcher
, but latestthree-stdlib
introduced its ownEventDispatcher
(pmndrs/three-stdlib#388) and their types do not match.How to reproduce: Using latest R3F and
three-stdlib
write this line of code:useThree().set({controls: OrbitControls})
Expected: Typescript should not complain.
Currently: TS complains.
Depending on what's decided, we may not need to change anything in R3F, more info here: pmndrs/three-stdlib#388 (comment)
The text was updated successfully, but these errors were encountered: