Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

three-stdlib>=2.34.1 controls are incompatible with R3F #3416

Open
RodrigoHamuy opened this issue Dec 18, 2024 · 0 comments
Open

three-stdlib>=2.34.1 controls are incompatible with R3F #3416

RodrigoHamuy opened this issue Dec 18, 2024 · 0 comments

Comments

@RodrigoHamuy
Copy link

RodrigoHamuy commented Dec 18, 2024

Most three-stdlib controllers like OrbitControls and others are incompatible with R3F controls API.

This is because R3F store controls: THREE.EventDispatcher | null (source) extends from THREE.EventDispatcher, but latest three-stdlib introduced its own EventDispatcher (pmndrs/three-stdlib#388) and their types do not match.

How to reproduce: Using latest R3F and three-stdlib write this line of code: useThree().set({controls: OrbitControls})
Expected: Typescript should not complain.
Currently: TS complains.

Depending on what's decided, we may not need to change anything in R3F, more info here: pmndrs/three-stdlib#388 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant