Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] remove react-test-renderer #3409

Open
krispya opened this issue Dec 6, 2024 · 7 comments
Open

[v9] remove react-test-renderer #3409

krispya opened this issue Dec 6, 2024 · 7 comments

Comments

@krispya
Copy link
Member

krispya commented Dec 6, 2024

react-test-renderer is deprecated and should be removed.

@joshuaellis
Copy link
Member

This is used for react-native testing – is there a better way now? I've been out of the loop with react-native for some time.

@krispya
Copy link
Member Author

krispya commented Dec 7, 2024

React officially recommends the React Testing Library. I don't know much about it myself but it is something we need to address since it won't be supported going forward.

@joshuaellis
Copy link
Member

Okay, we need to look at alts for RN before removing imo

@CodyJasonBennett
Copy link
Member

We will remove react-test-renderer or we cannot upgrade. Reconcilers are published in lockstep with React and are generally not forward or backwards compatible, especially React 19. Our options are looking for alternatives or building our own. I would simply suggest our react-nil if not for the primary/secondary renderer problem (only two concurrent renderers are supported, and they can't mismatch roles).

@joshuaellis
Copy link
Member

I don't think anyone is suggesting not removing it, we're just discussing what way is best to do it going forward for native 😊

@joshuaellis
Copy link
Member

lil' update – React Testing Library is for DOM, there is a react-native equivalent, but that uses react-test-renderer under the hood. We'll need to monitor the RN space and see what happens there because i'm not sure at the moment.

@krispya
Copy link
Member Author

krispya commented Dec 9, 2024

I asked Callstack and this is what they use: https://github.com/callstack/react-native-testing-library

Relevant: callstack/react-native-testing-library#1669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants