-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: v9 goals #2338
Comments
I'd also like to discuss making |
I don't think we can change defaults for lighting OOTB, problems are detailed in the linked issue. That might be a consideration for #2299 but the issue of |
Agreed. After a conversation with Paul, I'm making sure a pass on the frameloop modes is also on the to-do list. In particular |
What are your thoughts on updating to zustand v4? |
I'm in favor, the typing is hugely improved and so is compatibility with context. But it isn't a trivial update. Is it something you would be interested in spearheading? I can contribute. |
Yeah, I think so. When upgrading to r3f v8 I erroneously update zustand to v4. I had to revert back of course but not until I had some fair share of migration experience (we use it too) |
That would be great. If you start a branch, I can do review and assist. |
Just did this with |
Thanks so much for all your hard work Cody. I wanted to add here some type exports for the different r3f props which were previously exported as |
Hello! Whats the status of V9? I'm looking to use the lifecycle stages in |
Hey! So we have been working on projects in parallel to this one and trying out some of the v9 updates internally as we go along. For example, I am exploring alternatives to |
In the 9.0.0-beta.1 the declarations are missing, same as in #3331 Could we please get a new beta that includes the missing types declarations? |
I tested a bunch of stuff using the v9 and found that a lot of examples worked well, so thank you for your hard work on preparing for the release of react 19 I found two errors likely caused by changes in the react three fiber v9 beta 1 or react 19, I created a repository with a reproduction for two cases and added some explanations to the README I used Next.js 15 canary, because Next.js 15 comes with React 19 and because there is a Next.js Conf on Oct 24, 2023 during which they will likely announce the release of the first stable version of Next.js 15, so I assume that soon the amount of bug reports related to React 19 will surge I have a question though, the second error related to leva seems to be related to a change in React 19 so I assume I post a ticket about it in the leva repository, but for the first error related to the effectcomposer, I'm not sure is this belongs in this repository as it is likely connected to changes in the R3F v9 or should I open a ticket in the react three postprocessing repo? |
next.js 15 has just been released an hour ago https://github.com/vercel/next.js/releases/tag/v15.0.0 and with it comes the react 19 dependency. I've been trying to do the "happy path" upgrade via their supplied codemods but hitting a couple compile errors after updating r3f to v9 beta:
|
Thanks for doing the testing! We haven't touched v9 in a while waiting for React to get a new RC. Well that time has come. The best place to report issues is with the libraries they affect directly. Then the maintainers there can identify if the issues is their code or R3F's. |
@maggo this is because in the r3f beta 1 package (in /node_modules) there is a missing types directory, to fix this you need to install another version of r3f (for example 9.0.0-beta.0) in a seperate directory somewhere and then copy over the /node_modules/@react-three/fiber/dist/declarations to the r3f v9 beta 1 directory, if you need more have a look at the README of my r3f v9 tests repository, the basic page in /app has a working demo of nextjs 15 / react 19 and r3f v9, this is of course just a temporary fix, I'm sure the next release of r3f v9 will have fixed types |
I have fixed the issue with the typescript errors by just rolling back to alpha.8 instead of beta.1. |
I just released 9.0.0-rc.0 against React's 19.0.0-rc.0 with republished types and improvements from v8. React 19 is back to nightly builds for the meantime, and we'll resume releases once they go back to a scheme which leverages pinning. |
So we can expect Thanks for your work on this amazing library 🙏 |
It does support React 19 and you can find an RC right here: https://www.npmjs.com/package/@react-three/fiber/v/9.0.0-rc.1 We will keep as close to React's own release schedule as we can. |
Amazing, i wasn't 100% sure ! Thanks 🫡 @krispya |
FYI for others: React 19 officially released on Dec 5th: https://github.com/facebook/react/releases/tag/v19.0.0 I've tried many different variants from
For context we're using
The error is happening in |
To be clear, |
Closing this as it is out of date. v9 has become a compatibility update for React 19 with no breaking changes. Breaking changes are now moved to a future v10. |
It is indeed an issue with pmndrs/react-postprocessing#301 covers it. Thank you! |
Let's discuss some v9 goals here. These are all tentative right now.
Completed
useFrame
foruseUpdate
[v9] feat: implement update lifecycle with useUpdate #2279onUpdate
prop [v9] refactor!: remove onUpdate prop #2480updateStyle
fromSize
[v9] refactor!: removeupdateStyle
fromSize
#2489act
types for testing [v9] fix(types): don't declare unstable_act #2492v8.8.7
)React.StrictMode
across renderers [v9] fix: forward StrictMode #2547extend
overload for libraries [v9] experiment: extend factory overload #2785TODO
useLoader
forReact.use
: [v9] feat(cache): promise based caching with workers #3245scene
fromuseThree
is not always aTHREE.Scene
within portal #2725workflow
canvas prop #2299Pending
The text was updated successfully, but these errors were encountered: