Inconsistencies between ts an js regading layers

[dumaron]

Passing a number to layers prop on meshes isn't allowed in typescript, while it is in plain javascript.

As you can see in this sandbox it's possibile to set layers={1} in meshes. In typescript this won't compile because layers is of type Layers in threejs.

This sound a bit strange to me, but if we follow the original threejs layers example no compilation error will throw in ts + threejs:

mesh.layers.set(0);

In my opinion threejs types are a bit strange but somehow works, while in react-three-fiber right now I'm forced to do something like this:

useEffect(() => {
    mesh.current.layer = 0;
}, [])

Do you think this issue should be fixed here? I'm having other issues with the types of react-three-fiber, maybe we can try to improve our types apart from threejs.

That's actually more a bug but since it's not pressing and it involves three.js I tought it was better to open a discussion.

[drcmda]

should be fixed, this was due to a missing type.

as for <mesh layers={1} />, which is the correct form, take a look at the small section explaining setshortcuts: https://github.com/react-spring/react-three-fiber/blob/master/api.md#shortcuts-set tldr, any object that has a set method can be written directly into, this spares you having to fill in full objects, like new THREE.Color instead of just "white".

[drcmda]

what are the other problems you are having with types? myself, i know nothing about TS, i mostly just receive types by contribution. all types are kept here: https://github.com/react-spring/react-three-fiber/blob/master/src/three-types.ts you can make PRs if something's missing.

[dumaron]

I thought the same but oftentimes I'm not sure if it's a react-three-fiber or a threejs problem. I had some problems with GridHelper, I'll make a PR if I can understand how to improve correctly the types.

Thanks!