Set key function for layout images #7277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmph I guess we DO have image animation? Investigating the test failure... |
alexcjohnson
commented
Nov 21, 2024
| @@ -106,7 +106,7 @@ describe('Plots.transition', function() { | |||
| var pythonLogo = 'https://images.plot.ly/language-icons/api-home/python-logo.png'; | |||
|
|
|||
| function imageel() { | |||
| return gd._fullLayout._imageUpperLayer.select('image').node(); | |||
There was a problem hiding this comment.
I wasn't able to replicate the transition error on real code so started poking around the test itself. I don't understand it, but somehow doing this d3 selection was resetting the data stored with the image element, causing the key function I added in this PR to think the existing element wasn't the right one to use for the new image, so line 135 below expect(e1).toBe(e2); failed. Switching to a native JS querySelector fixed it. 🤷
|
Thanks very much for the PR. |
archmoj
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing my quest to make
layout.imageswork well for a custom tile server - panning around is currently glitchy, because when new tiles are added at or removed from the beginning of the array, we first shift the existing images to where the new start is, then update the URLs.This PR changes it so if there's an image at the same data or paper coordinates we'll leave the same element there, create new elements at new coordinates, and delete elements at coordinates where there is no longer an image. Two caveats to be aware of, but I think these are reasonable:
idand have that override this coordinate-based key. That would likely be necessary if we wanted to enable image animation, but we don't have that today.idattribute.